Problem/Motivation

Seems like the hal module is fighting until its last breath...

There are still a few references to it around in 10.0.x-dev even after its removal in #3049857: Remove HAL module from core and create a contrib project for it.

This issue is about the references in core/phpstan-baseline.neon which makes_any_ patch/MR against 10.0.x-dev altering core/phpstan-baseline.neon, which triggers a full PHPStan run, fail.

See for example https://www.drupal.org/pift-ci-job/2327905

Since this is slightly above just annoying, but blocks issues from getting in, put this on priority Major.

Steps to reproduce

Make change in core/phpstan-baseline.neon
See TestBot return red.

Proposed resolution

Remove remaining references to the hal module from core/phpstan-baseline.neon

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3266535

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Spokje created an issue. See original summary.

Spokje opened merge request !1890

spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs review
Related issues: +#3259355: Always do a full phpstan analysis on DrupalCI
spokje’s picture

spokje
Primary language Dutch
commented
Assigned: spokje » Unassigned

One of these days I'll remember to change the *bleeping* assigned field in one go...

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Priority: Major » Critical
Status: Needs review » Reviewed & tested by the community

IMO this is critical as it is blocking commit of anything else.

12:29:22 Running PHPStan on *all* files.
12:30:36 
12:30:36  [OK] No errors                                                                 
12:30:36 
12:30:36 
12:30:36 PHPStan: passed

Full run of PHPStan passed with this patch, therefore RTBC.

spokje’s picture

spokje
Primary language Dutch
commented

Thanks @longwave!

IMO this is critical as it is blocking commit of anything else.

Technically "Anything else that changes core/phpstan-baseline.neon and thus triggers a full PHPStan run", but I'll happily take a Critical any day...

  • catch committed 9718e6d on 10.0.x 
    Issue #3266535 by Spokje: Remove remaining references to the hal module...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.0.x, thanks for the quick follow-up!

Spokje closed merge request !1890

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.