Problem/Motivation

When trying to replace content in a "Text with Summary" field, the summary value isn't searched and replaced.

Steps to reproduce

Create a content-type with a Text with Summary field and try to replace text entered in the summary.

Proposed resolution

Also search and replace in the summary field.

CommentFileSizeAuthor
#7 scanner-combined_patch_of_3266343_and_3266488.patch5.89 KBcgoffin
#6 scanner-summary_not_taken_into_account-3266488-6.patch4.75 KBcgoffin
#5 scanner-combined_patch_of_3266343_and_3266488.patch5.79 KBcgoffin
#2 scanner-summary_not_taken_into_account-3266488-2.patch4.64 KBcgoffin

Issue fork scanner-3266488

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

cgoffin created an issue. See original summary.

cgoffin’s picture

cgoffin commented
StatusFileSize
new scanner-summary_not_taken_into_account-3266488-2.patch4.64 KB

Here a patch to also search and replace in the summary data.

cgoffin opened merge request !10

cgoffin’s picture

cgoffin commented
Status: Active » Needs review
cgoffin’s picture

cgoffin commented
StatusFileSize
new scanner-combined_patch_of_3266343_and_3266488.patch5.79 KB

I need a combination of this patch and the patch in https://www.drupal.org/project/scanner/issues/3266343. Here a patch file of the combined patches.

cgoffin’s picture

cgoffin commented
StatusFileSize
new scanner-summary_not_taken_into_account-3266488-6.patch4.75 KB

I removed too much when restructuring the query. Here the altered patch to restore the condition to check only for the selected language.

cgoffin’s picture

cgoffin commented
StatusFileSize
new scanner-combined_patch_of_3266343_and_3266488.patch5.89 KB

And also an updated version of the combined patch.

smustgrave’s picture

smustgrave commented
Version: 8.x-1.x-dev » 2.0.x-dev
Status: Needs review » Needs work

Lets update for 2.0.x and add some test coverage

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Related issues: +#3266343: Text not found in multilingual content

Would it be possible to leave the language fixes to #3266343: Text not found in multilingual content?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue tags: +Needs tests
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Category: Feature request » Bug report
Parent issue: » #3577750: Plan for Scanner 2.0.0

This is a bug, the summary field should be taken into account when present.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Assigned: Unassigned » damienmckenna

I'm going to take care of this, after I finish the other refactoring.

damienmckenna changed the visibility of the branch 2.0.x to hidden.

damienmckenna changed the visibility of the branch 8.x-1.x to hidden.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: Summary isn't taken into account » Support the 'summary' attribute on text_with_summary fields

damienmckenna opened merge request !76

  • damienmckenna committed f370c542 on 2.0.x 
    Issue #3266488 by cgoffin, damienmckenna: Support the 'summary'...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Fixed

Committed. Thank you @cgofin for the proposed fix, I used some of your MR code to solve the problem.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Assigned: damienmckenna » Unassigned
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue tags: -Needs tests