Proposed resolution

  • For K8s Schedule and other K8s Entities, the editing function will be implemented on the SPA side as well.
CommentFileSizeAuthor
#10 dev1.dataninja.net_clouds_dashboard_k8s_schedule_8b9b91a4-6e10-47a1-b563-397a79e39f59_mode=edit.png423.29 KByas
#8 dev1.dataninja.net_clouds_dashboard_k8s_schedule_8b9b91a4-6e10-47a1-b563-397a79e39f59_mode=edit(MacBook Air).png290.1 KByas
#6 20220228d.png347.6 KByas
#6 20220228c.png574.71 KByas
#6 20220228b.png393.64 KByas
#6 20220228a.png544.67 KByas

Issue fork cloud-3266446

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ryo Yamashita created an issue. See original summary.

Ryo Yamashita opened merge request !711

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

I was able to port K8sEditForm.php and K8sScheduleEditForm.php to the SPA side as well.
However, I have not checked the appearance of the K8s Schedule on the form.
Please check this code. Thanks!

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

As per discussion, please let us change the status to Needs work. Thanks

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

I fixed the warnings and errors that were occurring. Please review it. Thanks!

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work
StatusFileSize
new 20220228a.png544.67 KB
new 20220228b.png393.64 KB
new 20220228c.png574.71 KB
new 20220228d.png347.6 KB

@ryo-yamashita

Thank you for the update. I tested the patch and found something wrong behavior. Can you see my screenshots shown in below? Thanks!

1
2
3
4

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

I fixed the design and behavior of the <select>'s for editing the start_time and end_time in the K8s Schedule edit view.
Also, the labels of the save and delete buttons have been modified.
Please review it. Thanks!

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work
StatusFileSize
new dev1.dataninja.net_clouds_dashboard_k8s_schedule_8b9b91a4-6e10-47a1-b563-397a79e39f59_mode=edit(MacBook Air).png290.1 KB

@ryo-yamashita

Thank you for the fixes. It looks good, and can I ask you one thing for the cometic change? Please see the screenshot shown in below. Thanks!

1

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

I fixed the select boxs' design in the edit view. Please review it. Thanks!

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new dev1.dataninja.net_clouds_dashboard_k8s_schedule_8b9b91a4-6e10-47a1-b563-397a79e39f59_mode=edit.png423.29 KB

@ryo-yamashita

Thank you for the update. I tested the patch and it looks good to me now.

1

I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed 545cc02 on 5.x authored by Ryo Yamashita 
    Issue #3266446 by Ryo Yamashita, yas: Add the function to edit K8s...

  • yas committed 6d9d671 on 4.x authored by Ryo Yamashita 
    Issue #3266446 by Ryo Yamashita, yas: Add the function to edit K8s...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Ryo Yamashita opened merge request !717

ryo yamashita’s picture

ryo yamashita commented
Status: Fixed » Needs review

@yas

I have modified the code according to the coding standard. Please review it. Thanks!

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@ryo-yamashita

Thank you for supplying the hotfix. It looks good, I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed dbe4c3f on 5.x authored by Ryo Yamashita 
    Issue #3266446 by Ryo Yamashita, yas: Hotfix - Add the function to edit...

  • yas committed b18ddde on 4.x authored by Ryo Yamashita 
    Issue #3266446 by Ryo Yamashita, yas: Hotfix - Add the function to edit...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.