Closed (fixed)
Project:
Drupal core
Version:
9.4.x-dev
Component:
javascript
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
21 Feb 2022 at 16:27 UTC
Updated:
4 May 2022 at 16:29 UTC
Jump to comment: Most recent
Comments
Comment #2
longwavejsdom looks like a trivial update: https://github.com/jsdom/jsdom/blob/master/Changelog.md#1900
On the other hand, chalk needs work, as it needs to be loaded a different way: https://github.com/chalk/chalk/releases/tag/v5.0.0
But there is a note: "It's totally fine to stay on Chalk v4. It's been stable for years." - so I don't think this is critical for 9.4.x/10.0.x.
Comment #3
longwaveLooking at this a bit more, in order to migrate to chalk 5 I think we have to convert all our scripts from CommonJS to ESM as per https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c
Comment #4
nod_I think we can probably make it happen with the updated nodejs version and nightwatch 2. From what I remember nightwatch didn't like JS modules which is why everything is old school in the repo.
Comment #5
nod_let's forget about chalk in this issue. not sure why they were grouped :)
Comment #7
nod_Comment #8
longwaveAs trivial as can be for JS dependencies :)
Comment #9
alexpottCommitted and pushed 708f501cad to 10.0.x and 0a110d3487 to 9.4.x. Thanks!
Comment #13
xjm