Problem/Motivation

We are currently on Shepherd.js 8.3.1 but the latest version is 9.0.0. The major version drops supports for node 10, no other breaking change so we are not impacted.

Proposed resolution

Update to Shepherd.js 9.x on Drupal 10.0.x.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Shepherd.js is updated to 9.0.0. According to its release note there should be no breaking changes that affect our usage.

CommentFileSizeAuthor
#4 3265619-4.patch705.29 KBlongwave
#3 interdiff_3265619_2-3.txt703.54 KBandregp
#3 3265619-3.patch1.81 KBandregp
#2 3265619-2.patch704.78 KBandregp

Comments

lauriii created an issue. See original summary.

andregp’s picture

andregp commented
Status: Active » Needs review
StatusFileSize
new 3265619-2.patch704.78 KB

On this patch I replaced all references to shepherd 8.3.1 by 9.0.0 and updated the shepherd js files.

andregp’s picture

andregp commented
StatusFileSize
new 3265619-3.patch1.81 KB
new interdiff_3265619_2-3.txt703.54 KB

Here I updated shepherd.js integrity hash and dependencies on the yarn.lock file and also left the .js files to keep the patch smaller.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
StatusFileSize
new 3265619-4.patch705.29 KB

We also have the shepherd.js files located in assets/vendor/shepherd, they need updating.

The attached patch was created with

$ yarn add -D shepherd.js
$ yarn vendor-update
nod_’s picture

nod_
Primary language French
Location Lille
commented
Version: 9.4.x-dev » 10.0.x-dev
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Patch above is for 9.4,

can we have a patch for d10 also? thanks!

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

#4 applies to 10.0.x locally, adding a test to be sure.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 10.0.x-dev » 9.4.x-dev
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed
Issue tags: +9.4.0 release notes

Committed and pushed a388205e7b to 10.0.x and dfe7fd83c6 to 9.4.x. Thanks!

  • alexpott committed a388205 on 10.0.x 
    Issue #3265619 by andregp, longwave, lauriii, nod_: Update Shepherd.js...

  • alexpott committed dfe7fd8 on 9.4.x 
    Issue #3265619 by andregp, longwave, lauriii, nod_: Update Shepherd.js...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +10.0.0 release notes