Problem/Motivation

The -webkit vendor prefix is no longer needed on linear-gradient CSS values for any browsers after 2014: https://caniuse.com/?search=linear-gradient

Steps to reproduce

Proposed resolution

Remove any -webkit-linear-gradient CSS.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#9 remove-obsolete-webkit-linear-gradient.png40.97 KBgaurav-mathur
#9 after-patch-remove-obsolete-webkit-linear-gradient.png5.06 KBgaurav-mathur
#9 before-patch-remove-obsolete-webkit-linear-gradient.png8.24 KBgaurav-mathur
#8 Screenshot 2022-11-10 at 12.34.56 PM.png116.71 KBakram khan
#8 Screenshot 2022-11-10 at 12.35.10 PM.png124.61 KBakram khan
#6 3265596-6.patch5.79 KBlongwave
#5 3265596-5.patch37.15 KBlongwave
#3 3265596-3.patch36.25 KBlongwave

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

PostCSS is actually removing this for us already in some cases!

e.g. themes/claro/css/theme/ckeditor-dialog.pcss.css:

  background-image: -webkit-linear-gradient(top, #f6f6f3, #e7e7df);

This is automatically removed from themes/claro/css/theme/ckeditor-dialog.css.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review
StatusFileSize
new 3265596-3.patch36.25 KB

Status: Needs review » Needs work

The last submitted patch, 3: 3265596-3.patch, failed testing. View results

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Needs review
StatusFileSize
new 3265596-5.patch37.15 KB
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
StatusFileSize
new 3265596-6.patch5.79 KB

Rerolled.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Title: Clean up -webkit-linear-gradient CSS » Remove obsolete -webkit-linear-gradient CSS
akram khan’s picture

akram khan
Primary language English
Location Cuttack, Odisha
commented
StatusFileSize
new Screenshot 2022-11-10 at 12.35.10 PM.png124.61 KB
new Screenshot 2022-11-10 at 12.34.56 PM.png116.71 KB

Tested patch #6 it applied successfully and its remove -webkit-linear-gradient that are used

gaurav-mathur’s picture

gaurav-mathur commented
StatusFileSize
new before-patch-remove-obsolete-webkit-linear-gradient.png8.24 KB
new after-patch-remove-obsolete-webkit-linear-gradient.png5.06 KB
new remove-obsolete-webkit-linear-gradient.png40.97 KB

Verified and applied patch #6 it works fine and remove all -webkit-linear-gradient that are there in css

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Needs review » Reviewed & tested by the community

Latest patch LGTM and passes tests!

  • bnjmnm committed 581813e7 on 10.1.x 
    Issue #3265596 by longwave, mherchel: Remove obsolete -webkit-linear-...

  • bnjmnm committed db0bd74a on 10.0.x 
    Issue #3265596 by longwave, mherchel: Remove obsolete -webkit-linear-...
bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Reviewed & tested by the community » Fixed

Committed to 10.1.x and cherry picked to 10.0.x since it is nondisruptive and 10 should have it's removals of obselete code occurring as early as possible within its release cycle.

Credit not granted for #8 or #9 as they do not include any information that is not already made known by the actual patch in #6. Screenshots are helpful for patches that result in visual changes to the UI, but are entirely unnecessary otherwise.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.