Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
A child issue of #3167880: [meta] Convert assertions involving use of xpath to WebAssert, where possible to complete conversions where possible. Several prior issues resolved most of the conversions, this is to catch most of the remaining ones.
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Issue fork drupal-3265574
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3265574-convert-remaining-assertions changes, plain diff MR !1857
Comments
Comment #3
mondrakeComment #4
mondrakeThis should be it. I did not try to convert cases where xpath results are traversed or part of more complex checking. Also, KernelTests are left out as Mink is not usable there.
Comment #5
mondrakeRerolled
Comment #6
mondrakererolled
Comment #7
mondrakererolled
Comment #9
longwaveLooking pretty good but this needs a rebase against 10.0.x I guess.
Comment #10
mondrakeAh, with a deprecation in the MR I think we need to target 10.1 now.
Comment #11
longwaveAs that is in tests only, I think we can still deprecate in 9.5.x for removal in 10.0.x.
Comment #12
mondrakeLet's try that then, thx
Comment #13
mondrakeComment #14
mondrakeAdjusted deprecation and added CR
Comment #15
longwaveThanks, I've re-reviewed the whole patch and don't see any issues.
Comment #16
alexpottCommitted and pushed c900c8d35c to 10.1.x and 8c9655ec2d to 10.0.x and f1e2cfde0a to 9.5.x. Thanks!
Committed 5551334 and pushed to 9.4.x. Thanks!
Changed the deprecation to be for D11 because of how late in the 9.5 cycle we are.
Backported to 9.4.x to keep tests aligned but without the deprecation.