Add a detailed view to SPA (OpenStack Floating IPs)

Issue fork cloud-3265571

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

onotm created an issue. See original summary.

onotm opened merge request !692

onotm’s picture

onotm commented
Status: Active » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@onotm

Thank you for adding the detailed view. It looks good to me.

@ryo-yamashita

What do you think?

Thanks!

ryo yamashita’s picture

ryo yamashita commented

@yas

I checked this commit too. It looks good. Thanks!

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@ryo-yamashita

Thank you for your review.

@onotm

Could you please rebase the patch? It's now virtually RTBC; however I changed the status from Needs review to Needs work. Thanks!

onotm’s picture

onotm commented
Status: Needs work » Reviewed & tested by the community
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@onotm

Thank you for rebasing. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed c7f6831 on 5.x authored by onotm 
    Issue #3265571 by onotm, yas, Ryo Yamashita: Add a detailed view to SPA...

  • yas committed 11818ab on 4.x authored by onotm 
    Issue #3265571 by onotm, yas, Ryo Yamashita: Add a detailed view to SPA...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.