Problem/Motivation

PHPStan identified a duplicate key in MailManagerTest. It seems to have been changed by accident in #2663270: MailManager::mail() should run inside its own render context: it sends e-mails, not (cacheable) responses but there is no mention of why and it doesn't seem to have served a purpose.

Steps to reproduce

PHPStan results.

Proposed resolution

Replace second key with the original key.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#4 reroll_diff_2-4.txt656 byteseleonel
#4 3265429-3.patch1.17 KBeleonel
#2 3265429-2.patch1.18 KBneclimdul
fix-MailManagerTest-array-key.patch1.57 KBneclimdul

Comments

neclimdul created an issue. See original summary.

neclimdul’s picture

neclimdul
He/Him
commented
StatusFileSize
new 3265429-2.patch1.18 KB

shoot. made that off my test branch and the baseline diff doesn't apply. Realized it after I'd submitted. This should work though.

daffie’s picture

daffie commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

Patch looks good, but does need a reroll.

eleonel’s picture

eleonel
he/him
Primary language Spanish
Location Itoshima 🇯🇵
commented
StatusFileSize
new 3265429-3.patch1.17 KB
new reroll_diff_2-4.txt656 bytes
eleonel’s picture

eleonel
he/him
Primary language Spanish
Location Itoshima 🇯🇵
commented
Status: Needs work » Needs review
daffie’s picture

daffie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: 3265429-3.patch, failed testing. View results

daffie’s picture

daffie commented
Status: Needs work » Reviewed & tested by the community
Issue tags: -Needs reroll

Back to RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 10.0.x-dev » 9.4.x-dev
Status: Reviewed & tested by the community » Fixed

Committed ef36c2e and pushed to 10.0.x. Thanks!
Committed 0bf085b and pushed to 9.5.x. Thanks!
Committed 641bb74 and pushed to 9.4.x. Thanks!

Backported to 9.4.x (minus phpstan changes) as this is a test-only change.

  • alexpott committed ef36c2e on 10.0.x 
    Issue #3265429 by neclimdul, eleonel: Fix array keys in MailManagerTest

  • alexpott committed 0bf085b on 9.5.x 
    Issue #3265429 by neclimdul, eleonel: Fix array keys in MailManagerTest

  • alexpott committed 641bb74 on 9.4.x 
    Issue #3265429 by neclimdul, eleonel: Fix array keys in MailManagerTest...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.