Problem/Motivation
During Drupal 8, we added support for \Drupal::MINIMUM_SUPPORTED_PHP, which defines a PHP version that allows sites to run, but displays warnings on update and errors on the status report for existing sites. (New installations are not allowed except within the test runner.)
However, numerous tests now fail when MINIMUM_SUPPORTED_PHP is actually used, either due to issues with the test or possible regressions in HEAD.
One of these tests is Drupal\Tests\locale\Functional\LocaleTranslatedSchemaDefinitionTest.
Proposed resolution
Fix the tests. See #8.
There are three MRs:
- 3265377-FAIL increases the minimum supported PHP version so that the PHP 7.3 test environment will expose the bug, plus skips some other test failures covered in other issues.
- 3265377-prove-fix combines the failing version with the change to the test to prove that the issue is resolved.
- 3265377-fix-only is the version for commit.
Remaining tasks
Followups for other issues and to actually change the PHP version.
User interface changes
N/A
API changes
N/A
Data model changes
N/A
Release notes snippet
Issue fork drupal-3265377
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3265377-FAIL
changes, plain diff MR !1840
- 3265377-prove-fix
changes, plain diff MR !1855
- 3265377-fix-only
changes, plain diff MR !1856
Comments
Comment #3
xjmGo, tests, go.
Comment #4
xjm#3265412: QuickStartTestBase is incompatible with the current implementation of MINIMUM_SUPPORTED_PHP causes the other failures.
Comment #5
xjmComment #8
xjmSo this is another test that tries to do the right thing, but doesn't quite do so successfully:
The problem on PHP versions lower than
\Drupal::MINIMUM_SUPPORTED_PHPis that strings are only collected from the warnings page, and not from the second screen. Moving the$this->updateRequirementsProblem()call earlier, prior to the randomized translation, resolves this.Comment #9
xjmComment #10
daffie commentedThe 3 MR's convince me that the fix is the right one.
For me it is RTBC.
Comment #13
catchCommitted/pushed to 10.0.x, cherry-picked to 9.4.x and 9.3.x, thanks!