Problem/Motivation

In #3194084: Support functionality equivalent to ckeditor_stylesheets, several improvements to ie11.filter.warnings.es6.js were identified that would provide the same functionality with simpler code. However, those improvements were out of scope so they'll happen here instead.

Steps to reproduce

Proposed resolution

Reviewing the changes in the MR is likely easier than converting the solution to prose. Here's roughly it

  • Event listener isn't needed, only MutationObserver
  • MutationObserver callbacks can be nested, easier to read.
  • Functionality depending on the presence of an error class should use a data attribute instead since the class is technically supposed to impact presentation only.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#5 3265230-5-d10.patch11.8 KBlauriii

Issue fork drupal-3265230

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bnjmnm created an issue. See original summary.

bnjmnm’s picture

Title: Refactor ie11.filter.warnings.es6.js to simpler structure. » Refactor ie11.filter.warnings.es6.js to simpler structure & other improvements
Issue summary: View changes
Status: Active » Needs review

Wim Leers’s picture

Status: Needs review » Reviewed & tested by the community

Looking good! :)

Will need 9.3 + 9.4 patch.

lauriii’s picture

  • lauriii committed 122c48f on 10.0.x
    Issue #3265230 by bnjmnm, Wim Leers: Refactor ie11.filter.warnings.es6....

  • lauriii committed 9d5f1c1 on 9.4.x
    Issue #3265230 by bnjmnm, Wim Leers: Refactor ie11.filter.warnings.es6....

  • lauriii committed 0102c20 on 9.3.x
    Issue #3265230 by bnjmnm, Wim Leers: Refactor ie11.filter.warnings.es6....
lauriii’s picture

Version: 9.4.x-dev » 9.3.x-dev
Status: Reviewed & tested by the community » Fixed

Tested manually with IE 11 to confirm that this works as expected.

Committed 122c48f and pushed to 10.0.x. Also cherry-picked to 9.4.x and 9.3.x because CKEditor 5 is experimental. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.