Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
In #3194084: Support functionality equivalent to ckeditor_stylesheets, several improvements to ie11.filter.warnings.es6.js were identified that would provide the same functionality with simpler code. However, those improvements were out of scope so they'll happen here instead.
Steps to reproduce
Proposed resolution
Reviewing the changes in the MR is likely easier than converting the solution to prose. Here's roughly it
- Event listener isn't needed, only MutationObserver
- MutationObserver callbacks can be nested, easier to read.
- Functionality depending on the presence of an
error
class should use a data attribute instead since the class is technically supposed to impact presentation only.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#5 | 3265230-5-d10.patch | 11.8 KB | lauriii |
|
Issue fork drupal-3265230
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3265230-refactor-ie11.filter.warnings.es6.js-to changes, plain diff MR !1829
Comments
Comment #2
bnjmnmComment #4
Wim LeersLooking good! :)
Will need 9.3 + 9.4 patch.
Comment #5
lauriiiComment #9
lauriiiTested manually with IE 11 to confirm that this works as expected.
Committed 122c48f and pushed to 10.0.x. Also cherry-picked to 9.4.x and 9.3.x because CKEditor 5 is experimental. Thanks!