Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork diff-3264928

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

JeroenT created an issue. See original summary.

JeroenT opened merge request !13

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Parent issue: » #3264927: [META] Drupal 10 support
jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Parent issue: #3264927: [META] Drupal 10 support »
berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Most visible test fails are the PHP 8.1 problem now that #3256598: Deprecated function: strlen(): Passing null to parameter #1 ($string) of type string is deprecated is fixing, probably makes sense to keep that separate and fix that first. but I suppose we could include the change to see what else is failing.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented

I closed #3255886: The "access_check.node.revision" service is deprecated. You should use the 'access_check.entity' service instead. as a duplicate.
merlin06 and heddn did some work there, so it would be kind to give them credits on this issue.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Postponed » Needs work
berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Rebased on 8.x-1.x, down to two failing tests. These tests are also failing on 9.4, I suspect that's a string change around the delete forms that happened there.

As I'm not sure when exactly this will be committed (due to requiring 9.4), it might make sense to fix those fails separately.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs work » Needs review

I found the problem.
In Drupal 9.3, the content (with the revision table) was shown first. The tabs were shown beneath the content.

So $this->clickLink(t('Delete'), 0); clicked the first Delete button in the revision table.

In Drupal 9.4 and 10, the tabs were shown above the content. So $this->clickLink(t('Delete'), 0); resulted in deleting the node instead of a revision. This is why the delete message was no longer found.

I updated the selector, so now this should work in all Drupal versions.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented

Because we need to raise the min version to 9.3 I would vote for creating a new release now, then committing this patch and creating another release.
I think since the module has not much activity it's ok to do that. Drupal 9.2 will be EOL in 4 months anyway.

phenaproxima made their first commit to this issue’s fork.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Fixed

Merged into 8.x-1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.