Problem/Motivation

Add the function to edit K8s Namespace in the SPA.

Issue fork cloud-3264898

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ryo Yamashita created an issue. See original summary.

Ryo Yamashita opened merge request !689

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

I created an edit form for K8s Namespace, also in SPA. Please review it. Thanks!

yas made their first commit to this issue’s fork.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@ryo-yamashita

I posted my comments. Can you check? Thanks!

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

I fixed the code for your comments. Please review it again. Thanks!

  • yas committed 0b2780c on 5.x authored by Ryo Yamashita 
    Issue #3264898 by Ryo Yamashita, yas: Add the function to edit K8s...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@ryo-yamashita

Thank you for the update. It looks good to me now. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed 54e4be4 on 4.x authored by Ryo Yamashita 
    Issue #3264898 by Ryo Yamashita, yas: Add the function to edit K8s...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.