Closed (fixed)
Project:
Commerce KBC Paypage
Version:
1.0.0
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
15 Feb 2022 at 13:20 UTC
Updated:
6 Jun 2024 at 19:04 UTC
Jump to comment: Most recent
Comments
Comment #3
matthijsThis might be a good idea, but I would prefer to use an event instead of a hook. Could you update your MR accordingly?
Also prevent the use of
\Drupal, we should be able to use dependency injection.ps: sorry for the delayed response, apparently I wasn't following the issues of this project.
Comment #4
james.williamsAs you might have guessed, Steve is no longer actively working on this. But I might pick it up for him :)
Comment #7
james.williamsOK; I've opened MR !2 which uses a modern event instead of a hook, which I believe does the trick. That said, I can't easily test it as my client doesn't have a easily-usable test environment. I can certainly get as far as the initial KBC offsite payment page, and parameters altered via this method do indeed get passed along as intended, I just can't then actually proceed from my local test site.
Comment #9
matthijsThanks for the MR, it looks okay (I can't easily test it either), so I merged it.