Problem/Motivation

The module contains few deprecations for 10.0 core

Proposed resolution

Remove deprecated mentions and code

Remaining tasks

review/commit

User interface changes

No

API changes

No

Data model changes

No

CommentFileSizeAuthor
#9 3264061-9.patch2.34 KBandypost
#2 3264061-2.patch3.09 KBandypost
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

andypost created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Issue summary: View changes
Status: Active » Needs review
FileSize
3264061-2.patch3.09 KB

only 2

Status: Needs review » Needs work

The last submitted patch, 2: 3264061-2.patch, failed testing. View results

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Needs work » Needs review
daffie’s picture

daffie CreditAttribution: daffie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

  • catch committed 22859f8 on 10.0.x 
    Issue #3264061 by andypost: Remove deprecated functions from image...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed 22859f8 and pushed to 10.0.x. Thanks!

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake commented
Status: Fixed » Needs work

This has caused an off-synch of the PHPStan baseline,

Running PHPStan on *all* files.
------ --------------------------------------------------------------------------------
Line core/modules/media/src/Plugin/Field/FieldFormatter/MediaThumbnailFormatter.php
------ --------------------------------------------------------------------------------
62 Method
Drupal\image\Plugin\Field\FieldFormatter\ImageFormatter::__construct(
) invoked with 9 parameters, 10 required.
------ --------------------------------------------------------------------------------

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Needs work » Needs review
FileSize
3264061-9.patch2.34 KB

The follow-up, nice catch!

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented

I think it better to rollback as new argument needs deprecation notice https://www.drupal.org/about/core/policies/core-change-policies/drupal-d...

Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje as a volunteer commented
Priority: Normal » Major

Blocking D10 removal patch in #3227033-110: Remove Quick Edit from core (See https://www.drupal.org/pift-ci-job/2319582)

Since that issue has Priority Major, bumping this to major as well.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented

Wait I think that is fixed by #3255887: MediaThumbnailFormatter => Calling ImageFormatter::__construct() without the $file_url_generator argument is deprecated in drupal:9.3.0, which I just committed to 10.0.x (and will be backported to 9.4.x and 9.4.x), so we might not need to roll back here.

Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje as a volunteer commented
Priority: Major » Normal

Indeed fixed by #3255887: MediaThumbnailFormatter => Calling ImageFormatter::__construct() without the $file_url_generator argument is deprecated in drupal:9.3.0, back to Normal again.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Needs review » Fixed

it's already fixed in 10.0.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.