Problem/Motivation

When add an library js thats depends on drupal.editor.admin only, this library don't declare dependency directly for core/underscore causing an exception.

Steps to reproduce

Create an library thats depends on drupal.editor.admin only and include in the page.

Proposed resolution

Add dependendy for core/underscore in drupal.editor.admin library.

CommentFileSizeAuthor
#3 drupal_editor_admin_needs_declare_dependency_for_core_underscore-3263873-3.patch388 bytesljcarnieri

Comments

ljcarnieri created an issue. See original summary.

ljcarnieri’s picture

ljcarnieri commented
Title: drupal.editor.admin missing declare dependency for core/underscore » drupal.editor.admin needs declare dependency for core/underscore
ljcarnieri’s picture

ljcarnieri commented
StatusFileSize
new drupal_editor_admin_needs_declare_dependency_for_core_underscore-3263873-3.patch388 bytes

The patch for fix the problem.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Reviewed & tested by the community

Thanks for the patch. The closure shows that editor.admin.js uses underscore:

})(jQuery, _, Drupal, document);

so the dependency should be added, and this patch is one line that does exactly that.

  • lauriii committed 97ff906 on 10.0.x 
    Issue #3263873 by ljcarnieri, longwave: drupal.editor.admin needs...

  • lauriii committed 0e90ae9 on 9.4.x 
    Issue #3263873 by ljcarnieri, longwave: drupal.editor.admin needs...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Priority: Minor » Normal
Status: Reviewed & tested by the community » Fixed

Committed 97ff906 and pushed to 10.0.x. Also cherry-picked to 9.4.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.