Problem/Motivation

Coder 8.3.14 is released, so we should update our dependency.

Steps to reproduce

Proposed resolution

Update the dependency.
Remove the --runtime-set installed_paths switch from calls to PHPCS, as Coder now depends on dealerdirect/phpcodesniffer-composer-installer which registers sniffs automatically.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Coder has been updated to 8.3.15. This version will automatically set up Drupal coding standards sniffs in PHP_CodeSniffer thanks to a new dependency on dealerdirect/phpcodesniffer-composer-installer.

CommentFileSizeAuthor
#14 3262874-9.5.x-14.patch13.31 KBspokje
#14 3262874-9.4.x-14.patch13.13 KBspokje
#9 raw_diff_6-9.txt11.6 KBspokje
#9 3262874-9.patch13.29 KBspokje
#6 reroll_diff_3262874_4-6.txt2.13 KBankithashetty
#6 3262874-6.patch13.59 KBankithashetty
#4 3262874-4.patch13.59 KBlongwave
#2 3262874-2.patch17.33 KBlongwave

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review
StatusFileSize
new 3262874-2.patch17.33 KB 
+------------------------------------------------+--------+--------+
| Dev Changes                                    | From   | To     |
+------------------------------------------------+--------+--------+
| drupal/coder                                   | 8.3.13 | 8.3.14 |
| dealerdirect/phpcodesniffer-composer-installer | NEW    | v0.7.2 |
| phpstan/phpdoc-parser                          | NEW    | 1.2.0  |
| slevomat/coding-standard                       | NEW    | 7.0.18 |
+------------------------------------------------+--------+--------+

Confirmed locally that phpcs still runs clean.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

it may need release note snippet as 3 new dev-dependency added but good to go

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
StatusFileSize
new 3262874-4.patch13.59 KB

Rerolled.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs review
Issue tags: +Needs release note

I think we need a basic dependency evaluation for the development dependencies.

ankithashetty’s picture

ankithashetty
Location Karnataka, India
commented
StatusFileSize
new 3262874-6.patch13.59 KB
new reroll_diff_3262874_4-6.txt2.13 KB

Rerolled the patch #4, thanks!

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Needs work

NW for #5

spokje’s picture

spokje
Primary language Dutch
commented
Assigned: Unassigned » spokje
spokje’s picture

spokje
Primary language Dutch
commented
Title: Update Coder to 8.3.14 » Update Coder to 8.3.15
StatusFileSize
new 3262874-9.patch13.29 KB
new raw_diff_6-9.txt11.6 KB

Coder released 8.3.15 recently: https://www.drupal.org/project/coder/releases/8.3.15

Let's do a reroll for that version.

+------------------------------------------------+--------+--------+
| Dev Changes                                    | From   | To     |
+------------------------------------------------+--------+--------+
| drupal/coder                                   | 8.3.13 | 8.3.15 |
| dealerdirect/phpcodesniffer-composer-installer | NEW    | v0.7.2 |
| phpstan/phpdoc-parser                          | NEW    | 1.5.1  |
| slevomat/coding-standard                       | NEW    | 7.2.0  |
+------------------------------------------------+--------+--------+
spokje’s picture

spokje
Primary language Dutch
commented

Stab at dependency evaluation

Note #1: Never done this before
Note #2: After "evaluating the evaluations", they should be added to https://www.drupal.org/about/core/policies/core-dependency-policies/core-dependency-release-cycles-security-information-and-evaluation-criteria#dev

dealerdirect/phpcodesniffer-composer-installer
Repository https://github.com/PHPCSStandards/composer-installer
Release cycle Likely to change only when composer or PHP_CodeSniffer changes.
Security policies None. This is a dev tool and will not be present on production. This is a composer installer plugin that allows for easy installation of PHP_CodeSniffer coding standards (rulesets).
Security issue reporting N/a
Contact(s) franck.nijhof [at] dealerdirect.com

phpstan/phpdoc-parser
Repository https://github.com/phpstan/phpdoc-parser
Release cycle Frequent. Version 1.0 was released in Sep 2021. We are already on 1.5.1.
Security policies None. This is a dev tool and will not be present on production. This is a next generation phpDoc parser with support for intersection types and generics, which is used by Coder.
Security issue reporting N/a
Contact(s) https://github.com/ondrejmirtes

slevomat/coding-standard
Repository https://github.com/slevomat/coding-standard
Release cycle Frequently adding new sniffs.
Security policies None. This is a dev tool and will not be present on production. This provides sniffs for PHP_CodeSniffer and is used by Coder.
Security issue reporting N/a
Contact(s) https://github.com/kukulich
spokje’s picture

spokje
Primary language Dutch
commented
Assigned: spokje » Unassigned
Status: Needs work » Needs review
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs release note

Added a release note snippet. I assume we want to backport this to 9.5.x as well, and maybe 9.4.x if we are quick enough?

This unblocks #3048495: Fix Drupal.Semantics.FunctionTriggerError coding standard and perhaps some more coding standards issues.

spokje’s picture

spokje
Primary language Dutch
commented
Related issues: +#3048495: Fix Drupal.Semantics.FunctionTriggerError coding standard, +#2719663: Fix 'Drupal.Commenting.InlineComment.InvalidEndChar' coding standard, +#3046696: Move from serialized columns to JSON encoded data wherever possible, or use allowed_classes, +#2950031: Missing Description for testing modules in core

Thanks @longwave

...and perhaps some more coding standards issues.

Looking at the changes between the current 8.3.13 and the new 8.3.15 here: https://github.com/pfrenssen/coder/compare/8.3.13...8.3.15, these are the new/improved sniffs:

I've added all the d.o. issues that I could find that could be helped by those changes

spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new 3262874-9.4.x-14.patch13.13 KB
new 3262874-9.5.x-14.patch13.31 KB
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 10.0.x-dev » 9.4.x-dev
Status: Reviewed & tested by the community » Fixed
Issue tags: +9.4.0 release notes

Committed bb0fa10 and pushed to 10.0.x. Thanks!
Committed 91f04e6 and pushed to 9.5.x. Thanks!
Committed 37d6841 and pushed to 9.4.x. Thanks!

  • alexpott committed bb0fa10 on 10.0.x 
    Issue #3262874 by Spokje, longwave, ankithashetty, catch, andypost:...

  • alexpott committed 91f04e6 on 9.5.x 
    Issue #3262874 by Spokje, longwave, ankithashetty, catch, andypost:...

  • alexpott committed 37d6841 on 9.4.x 
    Issue #3262874 by Spokje, longwave, ankithashetty, catch, andypost:...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Added dependencies to https://www.drupal.org/about/core/policies/core-dependency-policies/core...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.