Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
We're removed this in #3097889: Remove deprecated theme functions but there's 2 mentions left
Steps to reproduce
Proposed resolution
clean-up mentions as confising
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#18 | 3262500-18.patch | 1.43 KB | andypost |
|
Comments
Comment #2
catchComment #3
catchComment #4
andypostMaybe it should be moved to some testing trait?
Surely it should not be a part of public API
Comment #5
andypostComment #6
catchIt's called in core in Drupal 9 because we didn't actually remove support for theme functions, so it can't be moved to testing. However we're already removing it in 10.x, so it can just be @internal in core.
Comment #7
Gábor HojtsyCreated https://www.drupal.org/node/3262533 for change record. @catch's reasons souns reasonable to mark it internal rather than deprecating the function.
Comment #8
andypost+1 rtbc as this function will gine in 10.0.x
Comment #10
catchRandom test failure.
Comment #11
alexpottCommitted and pushed f64e3344b2f to 10.0.x and 0725a14d512 to 9.4.x and be9d3fb4840 to 9.3.x. Thanks!
Backported to 9.3.x since this is a docs only patch and getting the info as soon as possible is useful.
Comment #16
alexpottReverted from 10.0.x to allow #3097889: Remove deprecated theme functions in without re-rolling.
Comment #17
andypostre-queued last patch
Comment #18
andypostre-purpose the issue
Comment #19
longwaveComment #20
alexpottCommitted 0c8a680 and pushed to 10.0.x. Thanks!
Let's leave the original issue title as it is more important.