Problem/Motivation

We're removed this in #3097889: Remove deprecated theme functions but there's 2 mentions left

Steps to reproduce

Proposed resolution

clean-up mentions as confising

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

catch created an issue. See original summary.

catch’s picture

Title: Mark drupal_find_theme_function() @internal or @deprecated in Drupal 9 » Mark drupal_find_theme_functions() @internal or @deprecated in Drupal 9
catch’s picture

Title: Mark drupal_find_theme_functions() @internal or @deprecated in Drupal 9 » Mark drupal_find_theme_functions() @internal in Drupal 9
Status: Active » Needs review
FileSize
531 bytes
andypost’s picture

Issue tags: +Needs change record

Maybe it should be moved to some testing trait?

Surely it should not be a part of public API

andypost’s picture

Issue tags: +@deprecated, +Kill includes
catch’s picture

It's called in core in Drupal 9 because we didn't actually remove support for theme functions, so it can't be moved to testing. However we're already removing it in 10.x, so it can just be @internal in core.

Gábor Hojtsy’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs change record

Created https://www.drupal.org/node/3262533 for change record. @catch's reasons souns reasonable to mark it internal rather than deprecating the function.

andypost’s picture

+1 rtbc as this function will gine in 10.0.x

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: 3262500.patch, failed testing. View results

catch’s picture

Status: Needs work » Reviewed & tested by the community

Random test failure.

alexpott’s picture

Version: 9.4.x-dev » 9.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed f64e3344b2f to 10.0.x and 0725a14d512 to 9.4.x and be9d3fb4840 to 9.3.x. Thanks!

Backported to 9.3.x since this is a docs only patch and getting the info as soon as possible is useful.

  • alexpott committed f64e334 on 10.0.x
    Issue #3262500 by catch, andypost: Mark drupal_find_theme_functions() @...

  • alexpott committed 0725a14 on 9.4.x
    Issue #3262500 by catch, andypost: Mark drupal_find_theme_functions() @...

  • alexpott committed be9d3fb on 9.3.x
    Issue #3262500 by catch, andypost: Mark drupal_find_theme_functions() @...

  • alexpott committed e9b366c on 10.0.x
    Revert "Issue #3262500 by catch, andypost: Mark...
alexpott’s picture

Reverted from 10.0.x to allow #3097889: Remove deprecated theme functions in without re-rolling.

andypost’s picture

Status: Fixed » Needs review

re-queued last patch

andypost’s picture

Title: Mark drupal_find_theme_functions() @internal in Drupal 9 » Remove leftover mentions of drupal_find_theme_functions() in Drupal 10
Version: 9.3.x-dev » 10.0.x-dev
Issue summary: View changes
FileSize
1.43 KB

re-purpose the issue

longwave’s picture

Status: Needs review » Reviewed & tested by the community
alexpott’s picture

Title: Remove leftover mentions of drupal_find_theme_functions() in Drupal 10 » Mark drupal_find_theme_functions() @internal in Drupal 9
Status: Reviewed & tested by the community » Fixed

Committed 0c8a680 and pushed to 10.0.x. Thanks!

Let's leave the original issue title as it is more important.

  • alexpott committed 0c8a680 on 10.0.x
    Issue #3262500 by andypost: Remove leftover mentions of...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.