Closed (fixed)
Project:
Drupal core
Version:
9.3.x-dev
Component:
javascript
Priority:
Major
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
3 Feb 2022 at 09:11 UTC
Updated:
25 Feb 2022 at 15:34 UTC
Jump to comment: Most recent
Comments
Comment #2
nod_Comment #3
wim leersI would love to RTBC this, but don't feel remotely qualified. I don't know enough about how this works.
But, bumping to since this blocks #3228464: API for contrib projects to load CKEditor translations (which is and essential for the CKEditor 5 module to become stable.)
Comment #4
lauriiiLooks good. Using async/await style everywhere in the file makes sense and makes it much easier to understand.
Comment #7
bnjmnmThe longest part of reviewing this for commit was the time required to truly understand what assets.js was doing prior to the changes here. The fact that it took as long as it did for me to grok it helps justify the changes here. The changes here make the file significantly easier to understand. With these changes, this file may be maintainable by more than a select elite 🙂.
Comment #8
wim leers+1!
Comment #9
nod_This needs to be backported to 9.3 if we want to have #3228464: API for contrib projects to load CKEditor translations for 9.3
Comment #10
wim leers#9++ — I don't see the risk in doing so? But maybe I'm missing something? 🤔
Comment #11
bnjmnmComment #13
bnjmnmWanted feedback on 9.3 and got it. This has been added to that version as well.
Comment #14
wim leersYay! :)