Update to CKEditor5 v32.0.0

@hooroomoo I see you've created a single commit that does everything. It'd be better to first have a commit that only changes package.json. And then a second commit that contains the build results. Because then rebasing becomes a lot simpler!

I have no idea what triggers the

Drupal's JavaScript development dependencies are not installed. Run 'yarn install' inside the core directory.

error though.

Time to investigate the console:

00:01:01.148 ----------------   Starting yarn_install   ----------------
00:01:01.156 Directory created at /var/lib/drupalci/workspace/jenkins-drupal_patches-112078/ancillary/yarn_install
00:01:01.156 Executing yarn install for core nodejs dev dependencies.
00:01:01.156 sudo -u www-data yarn install --no-progress --non-interactive --cwd /var/www/html/core
00:01:01.549 yarn install v1.22.17
00:01:01.670 [1/5] Validating package.json...
00:01:01.675 [2/5] Resolving packages...
00:01:02.407 [3/5] Fetching packages...
00:01:22.752 error @ckeditor/ckeditor5-alignment@32.0.0: The engine "node" is incompatible with this module. Expected version ">=14.0.0". Got "12.22.1"
00:01:22.762 error Found incompatible module.
00:01:22.762 info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
00:01:22.806 Yarn install command returned code: yarn install v1.22.17
00:01:22.806 [1/5] Validating package.json...
00:01:22.806 [2/5] Resolving packages...
00:01:22.806 [3/5] Fetching packages...
00:01:22.806 info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
00:01:22.806 Yarn install failed; Proceeding anyways...
00:01:22.807 ---------------- Finished yarn_install in 21.658 seconds ---------------- 

uh oh … apparently DrupalCI is still on node 12.22.1. CKEditor 5 32.0.0 now requires node 14.

Why did they do that? The answer is in https://github.com/ckeditor/ckeditor5/issues/10972: because node 12 LTS ends in April, in less than 3 months.

Drupal core last bumped its node version in #3107918: Require Node.js 12.

I just opened #3261734: Require Node.js 16 to get Drupal core on version 14.

There is one very tricky consequence: the CKEditor 5 module is experimental, and can have commits to 9.3.x. But I doubt it is okay for Drupal 9.3.3 (latest stable release) to use node 12 and Drupal 9.3.4 to use node 14…

I defer to JS maintainers in Drupal core to decide how to proceed here. I think this is new territory…

FYI #3261734: Require Node.js 16 has itself been blocked for 3 weeks now: #3261753: Update Node.js to v16 on DrupalCI.

Clarifying that in the title.

#3261753: Update Node.js to v16 on DrupalCI has made some progress, but still not there yet.

#3261753: Update Node.js to v16 on DrupalCI is fixed.

Now awaiting #3261734: Require Node.js 16.

#3261734: Require Node.js 16 landed in 9.4 and 10, hopefully soon also in 9.3.

In any case, this is now finally unblocked! We'll need to redo this MR now. Probably simpler if we start a new one.

Random unrelated failure:

1) Drupal\FunctionalJavascriptTests\Ajax\AjaxTest::testInsertAjaxResponse
Page contains expected value: 
Failed asserting that false is true.

Re-testing…

Hm … again

1) Drupal\FunctionalJavascriptTests\Ajax\AjaxTest::testInsertAjaxResponse
Page contains expected value: 
Failed asserting that false is true.

But it's impossible that this patch causes that. That test doesn't even install the ckeditor5 module, and the patch doesn't touch anything besides CKEditor 5!

Re-testing again, now on 2 environments. Perhaps one of the test environments has something weird going on?

EDIT: cross-posted with #20.

Looks like 9.3 fails consistently, and looks like this is broken in HEAD too: https://www.drupal.org/pift-ci-job/2332384 (on all branches actually it seems?!) — perhaps this is related to #3258114: Upgrade Chromedriver?

Re-testing, should be geen now … 🤞

Applied #22 and:

• ✅ Patches looks great!
• ✅ It works in general (unsurprising given tests pass).
• ✅ Confirmed https://github.com/ckeditor/ckeditor5/issues/10891: html-support: Added support for the <script> elements. Closes #10891. (commit) → this unblocks #3245950: [upstream] <script> tag support in GHS, which is a major issue is fixed! ⇒ we'll be able to close #3245950: [upstream] <script> tag support in GHS once this lands.
• ✅ Confirmed <ol start>, <ol type> and <ol reversed can work if I add the necessary plugins (https://ckeditor.com/docs/ckeditor5/latest/features/lists/lists.html#com...) and the necessary configuration (https://ckeditor.com/docs/ckeditor5/latest/api/module_list_listpropertie...):
  

  Adding that is out of scope for this issue. It will require not only plugin definition changes, but also upgrade path additions to \Drupal\ckeditor5\Plugin\CKEditor4To5Upgrade\Core, test coverage for that, et cetera. We have #3261599: Use CKEditor 5's native <ol start> support (and also support <ol reversed>) for that.

I'm relieved I'm able to RTBC this on my first (thorough!) review — this one has been blocking so many things for so long! 🚀