Remove deprecated layout_builder module functions

One more to go:

core/modules/layout_builder/src/Element/LayoutBuilder.php
65:      @trigger_error('Calling LayoutBuilder::__construct() with the $messenger argument is deprecated in drupal:9.1.0 and will be removed in drupal:10.0.0. See https://www.drupal.org/node/3152690', E_USER_DEPRECATED);

Thank you, looks ready now if bot agrees.

RTBC for real this time :)

There are no deprecations in layout_builder.module but there are in the module, so changing title.

$ grep -r "@deprecated" core/* | grep -v "node_modules" | grep -i "layout_builder"
$ grep -r "@group legacy" core/* | grep -v "node_modules" | grep -i "layout_builder"
$ grep -ri getAvailableContexts\(SectionStorageInterface core

Looks good, grep did not find anything.

Checking my review and working on my local process to make sure I check everything. :-)

I applied the patch and re-ran the grep commands.

# grep -r "@deprecated" core | grep -v "node_modules" | grep -i layout_builder
# grep -r "@group legacy" core | grep -v "node_modules" | grep -i layout_builder
# grep -r "@trigger" core | grep -v "node_modules" | grep -i layout_builder
# grep -ri "sectionstoragetrait" core 

For a moment I wondered about the adding of the typehint in the layoutBuilder constructor but then I saw the deprecation warning just below. So that is fine.

Adding credit to longwave.

This looks ready to commit to me. I'll wait for another committer to confirm.

Last thing here is to check whether deprecations being removed (acutal API changes, not constructor ones and similar) have an issue on https://github.com/mglaman/phpstan-drupal/issues and create one linking to the CR if not. Can be done as part of the commit process. We should start doing that when we add new deprecations in the first place, but doing it on removal was suggested by @xjm as a way to fill in the old gaps. I just did some on #3244802: Remove BC layers in entity system.

Patch looks great to me. Leaving for @quietone to commit.

+++ b/core/modules/layout_builder/src/Context/LayoutBuilderContextTrait.php
@@ -30,26 +30,6 @@ protected function contextRepository() {
-   * @see https://www.drupal.org/node/3195121

+++ b/core/modules/layout_builder/src/Element/LayoutBuilder.php
@@ -48,22 +48,10 @@ class LayoutBuilder extends RenderElement implements ContainerFactoryPluginInter
-      @trigger_error('Calling LayoutBuilder::__construct() with the $messenger argument is deprecated in drupal:9.1.0 and will be removed in drupal:10.0.0. See https://www.drupal.org/node/3152690', E_USER_DEPRECATED);


+++ /dev/null
@@ -1,53 +0,0 @@
- * @see https://www.drupal.org/node/3091432

I think these are the three unique CRs removed by the patch. I checked and this patch removes all references to those three CRs.

Committed to 10.0.x.

Thank you!

Adding credit to catch and xjm for mentoring support.