Remove deprecations from search module

One more:

core/modules/search/src/SearchIndex.php
70:      @trigger_error('Calling ' . __METHOD__ . ' without $text_processor argument is deprecated in drupal:9.1.0 and will be required in drupal:10.0.0. See https://www.drupal.org/node/3078162', E_USER_DEPRECATED);

Thanks, this looks ready to go.

I agree I applied the patch and checked didn't find any occurrences of the removed functions.

Checking my review. :-)

The patch is removing a deprecations from \Drupal\search\SearchIndex\SearchIndex.php, so changing title.

The following greps returned nothing, so it is getting all the deprecations from the search module.

$ grep -r "@deprecated" core/* | grep -v "node_modules" | grep -i "search"
$ grep -r "@group legacy" core/* | grep -v "node_modules" | grep -i "search"
$ grep -r "@trigger" core/* | grep -v "node_modules" | grep -i "search"

I did notice that the Drupal deprecation policy does not have a section for removing/changing a constructor parameter. That has no impact on this being committed. I'llresearch that later.

This looks ready to commit to me. I'll wait 24 hours to allow for comments.

Added credit for longwave

Looks good to me too. The one "gotcha" I checked for was the removal of a hook invocation without a corresponding deprecation of the hook definition, but I confirmed that the invocation has just been moved to core/modules/search/src/SearchTextProcessor.php instead. The hook is still an API and still in use.

I added https://www.drupal.org/about/core/policies/core-change-policies/drupal-d... -- I guess we never did before because it falls under the "best-effort deprecation warnings for internal code" category.

Committed to 10.0.x.

Thank you!

xjm and I worked together on a call on this; adding credit for xjm and myself.