Problem/Motivation

Steps to reproduce

Content of file is deprecated for 10.0 so its time to get rid of it

Proposed resolution

remove the file and usage, make sure no

Remaining tasks

review/commit

User interface changes

no

API changes

no

Data model changes

No

Release notes snippet

CommentFileSizeAuthor
#19 3260615-19.patch14.01 KBandypost
#16 3260615-16.patch14.01 KBandypost
#14 3260615-14.patch14.66 KBandypost
#14 interdiff.txt672 bytesandypost
#9 3260615-9.patch14.01 KBandypost
#9 interdiff.txt841 bytesandypost
#7 3260615-7.patch13.65 KBandypost
#4 3260615-4.patch13.66 KBandypost
#4 interdiff.txt1.95 KBandypost
#2 3260615-2.patch11.71 KBandypost

Comments

andypost created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs review
StatusFileSize
new 3260615-2.patch11.71 KB

schemaapi is defined in 

core/lib/Drupal/Core/Database/database.api.php:237: * @defgroup schemaapi Schema API

Status: Needs review » Needs work

The last submitted patch, 2: 3260615-2.patch, failed testing. View results

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt1.95 KB
new 3260615-4.patch13.66 KB
daffie’s picture

daffie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

Needs a re-roll.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review
StatusFileSize
new 3260615-7.patch13.65 KB

re-roll

Status: Needs review » Needs work

The last submitted patch, 7: 3260615-7.patch, failed testing. View results

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt841 bytes
new 3260615-9.patch14.01 KB

Remove remains which left after #3210931: Remove deprecated update.inc functions

daffie’s picture

daffie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

quietone’s picture

quietone commented
Status: Reviewed & tested by the community » Needs work

I searched for the functions that are removed and got results for drupal_get_schema. 

$ grep -ri drupal_get_schema core
core/modules/system/tests/src/Functional/Module/InstallTest.php:   * Verify that drupal_get_schema() can be used during module installation.
core/scripts/dump-database-d6.sh:$schema = drupal_get_schema();
core/scripts/dump-database-d7.sh:$schema = drupal_get_schema();
voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented

we don't touch D6-D7 related scripts as I know in terms of deprecated functions replacement.

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented

Run this script at the root of an existing Drupal 6 installation.

That's mean the functions called in the sh scripts calling related D6/D7 API

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt672 bytes
new 3260615-14.patch14.66 KB

This function been removed in https://www.drupal.org/node/2467521 (early 8.x core) so probably needs follow-up to clean-up in separate issue as unrelated to the change but here's patch

andypost’s picture

andypost
he/him
Primary language Russian
commented

Also confirm that d6/7 scripts should not get changes

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new 3260615-16.patch14.01 KB

Filed issue as the #14 out of scope and should go to 9.4.x - #3261517: Clean-up stale reference to drupal_get_schema()

Patch is the same as #9

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

Back to RTBC, agree that the database dump scripts must be left alone and the stale reference can be dealt with elsewhere as it is relevant to 9.4.x as well.

The last submitted patch, 14: 3260615-14.patch, failed testing. View results

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new 3260615-19.patch14.01 KB

re-roll after #3260765: Remove deprecated code from menu-related subsystems

patching file core/includes/install.core.inc
patching file core/includes/schema.inc
patching file core/lib/Drupal/Core/DrupalKernel.php
Hunk #1 succeeded at 539 with fuzz 1 (offset -1 lines).
patching file core/tests/Drupal/KernelTests/Core/Extension/SchemaDeprecationTest.php
patching file core/tests/Drupal/KernelTests/Core/Extension/UpdateDeprecationTest.php

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 19: 3260615-19.patch, failed testing. View results

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review

looks unrelated failure 

There was 1 error:

1) Drupal\Tests\layout_builder\FunctionalJavascript\AjaxBlockTest::testAddAjaxBlock
Behat\Mink\Exception\ElementNotFoundException: Form field with id|name|label|value "settings[ajax_test]" not found.

Status: Needs review » Needs work

The last submitted patch, 19: 3260615-19.patch, failed testing. View results

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Reviewed & tested by the community

Bot failure

  • catch committed eee5624 on 10.0.x 
    Issue #3260615 by andypost, voleger, quietone, longwave: Remove...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed eee5624 and pushed to 10.0.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.