Closed (duplicate)
Project:
Drupal core
Version:
9.2.x-dev
Component:
action.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
23 Jan 2022 at 13:47 UTC
Updated:
24 Jan 2022 at 17:17 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
asishsajeev commentedPlease review.
Comment #3
akhildev.cs commentedhi,
the patch was working fine. Applied patch core/modules/action/src/ActionListBuilder.php cleanly
removes t() call. thankyou for patch
Comment #4
longwaveThanks for working on this.
In general, issues should not be scoped by file or module; instead, they should be scoped by making the exact specific change across as much of core as possible. Please see https://www.drupal.org/core/scope#files
In particular,
t()calls should be replaced based on whether the translation service is already available in the class, and more specifically, based on which base class it extends. (So, for example, one issue for form builders, one for controllers, one for list builders, and then splitting that up further only if the resulting patch is too large to be manageable.) We also need to decide the approach before we proceed with child issues. See #3113904: [META] Replace t() calls inside of classes for more discussion.Closing as a duplicate of that issue.