Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3260005-2.patch977 bytesasishsajeev

Comments

asishsajeev created an issue. See original summary.

asishsajeev’s picture

Status: Active » Needs review
StatusFileSize
new977 bytes

Please review.

akhildev.cs’s picture

hi,
the patch was working fine. Applied patch core/modules/action/src/ActionListBuilder.php cleanly
removes t() call. thankyou for patch

longwave’s picture

Status: Needs review » Closed (duplicate)

Thanks for working on this.

In general, issues should not be scoped by file or module; instead, they should be scoped by making the exact specific change across as much of core as possible. Please see https://www.drupal.org/core/scope#files

In particular, t() calls should be replaced based on whether the translation service is already available in the class, and more specifically, based on which base class it extends. (So, for example, one issue for form builders, one for controllers, one for list builders, and then splitting that up further only if the resulting patch is too large to be manageable.) We also need to decide the approach before we proceed with child issues. See #3113904: [META] Replace t() calls inside of classes for more discussion.

Closing as a duplicate of that issue.