Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Similar to #3257583: Olivero: Refactor tabs CSS to make use of modern CSS.
Because Drupal 10 does not support IE11, we can make better use of CSS variables and holistically refactor components to make them more understandable, extendable, and resilient.
This issue brings better componentization, extendability, and organization to Olivero's dropbutton component.
Comment | File | Size | Author |
---|---|---|---|
#10 | interdiff-9.10.txt | 2.51 KB | mherchel |
#10 | 3259929-10.patch | 14.16 KB | mherchel |
| |||
#9 | diff_6-9.txt | 366 bytes | kostyashupenko |
#9 | 3259929-9.patch | 14.12 KB | kostyashupenko |
| |||
#6 | interdiff-4-6.txt | 1.08 KB | mherchel |
Comments
Comment #2
mherchelComment #3
mherchelFixing some ordering and nesting.
Comment #4
mherchelRe-roll of #3
Comment #5
andy-blumThis causes a dropbutton with (unrealistically) long text to overflow the page causing horizontal scroll. We probably would prefer having the display of the button break over multiple lines but all be visible.
we need the
.
on the nested dropbutton-wrapper classComment #6
mherchelThis is out of scope for this issue, as it's pre-existing. We could easily set a max-width, but this causes even more issues with dropbuttons overlapping other dropbuttons. This leads down a whole difficult road (I went down this with Claro a bit). The proper solution is the split-button component.
I fixed the selector issue (great catch!).
Updated patch and interdiff attached.
Comment #7
andy-blumlgtm
Comment #8
quietone CreditAttribution: quietone at PreviousNext commentedPatch no longer applies.
Comment #9
kostyashupenkoHere it is :)
Comment #10
mherchel@kostyashupenko I don't see the changes in that patch.
Uploading new patch.
Comment #11
andy-blumChanges from interdiff 9-10 look good. RTBC
Comment #12
mherchelOpened followup #3302052: Olivero footer can obscure bottom of dropbutton dropdown
Comment #15
lauriiiCommitted 4b9c19c and pushed to 10.1.x and cherry-picked to 10.0.x. Thanks!