Thanks, reviewed and merged.

Issue fork paragraphs_sets_plugins_ui-3259726

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

gilmord created an issue. See original summary.

Yurii O. made their first commit to this issue’s fork.

Yurii O. opened merge request !1

gilmord’s picture

gilmord
Location 🇺🇦Ukraine
commented

Hi, Yurii

a few notes to your MR:
- once we have "isset" check of the element key - we do not need the is_array check anymore
- please keep the "if" statement in a few lines to not exceed the 60 chars per line limit to match the coding standards
- extra brackets around the "isset" check looks excessive

Yurii O. opened merge request !3

gilmord’s picture

gilmord
Location 🇺🇦Ukraine
commented
Issue summary: View changes
Status: Active » Fixed

Yurii O. closed merge request !1

Yurii O. closed merge request !3

gilmord’s picture

gilmord
Location 🇺🇦Ukraine
commented
Status: Fixed » Closed (fixed)
interdruper’s picture

interdruper commented
Category: Bug report » Support request

Hi @gilmord, thanks for the module!
I do not see the commit for this issue in the 1.0.1 release, nor in 1.0.x-dev.
Could you please check?
Thanks in advance.

gilmord’s picture

gilmord
Location 🇺🇦Ukraine
commented
Assigned: Unassigned » gilmord
Status: Closed (fixed) » Active

Hi @interdruper
you are right, not sure how this happened
I will fix it

gilmord opened merge request !5

gilmord’s picture

gilmord
Location 🇺🇦Ukraine
commented
Assigned: gilmord » Unassigned
Status: Active » Needs review

@interdruper fixed in 1.0.2 please confirm

interdruper’s picture

interdruper commented
Status: Needs review » Reviewed & tested by the community

Yep, it seems ok now. Thanks!

gilmord’s picture

gilmord
Location 🇺🇦Ukraine
commented
Status: Reviewed & tested by the community » Fixed
gilmord’s picture

gilmord
Location 🇺🇦Ukraine
commented
Status: Fixed » Closed (fixed)