We need some tests for this. We don't need to test Drupal core. We need to render the block in a Functional? test and review that is rendered properly.

Issue fork whatsapp-3259603

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

pcambra created an issue. See original summary.

pcambra’s picture

Version: 7.x-1.x-dev » 1.x-dev
pcambra’s picture

- Test 1: Functional test. Visits the '/admin/config/services/whatsapp' url, checks that the form is correct and the value is saved as expected. Needs to also verify that users without the right permissions can access the page.

- Test 2: Kernel test. Places the whatsapp block in a region of the homepage (or a page created for this test in a routing file of a whatsapp_test), renders the block and checks if the javascript tag is injected as expected.

beagaliana made their first commit to this issue’s fork.

beagaliana’s picture

Status: Active » Needs review

  • beagaliana committed 7c59c18 on 3259603-add-fuct-test
    Issue #3259603 by beagaliana: Add a fuctional test that checks the form...
  • beagaliana committed 59deeea on 3259603-add-fuct-test
    Issue #3259603 by beagaliana: Add another key to test multiple choice
    

  • beagaliana committed cdd211e on 3259603-add-fuct-test
    Issue #3259603 by beagaliana: Remove unneeded empty line
    

  • pcambra committed 6a44b06 on 1.x authored by beagaliana
    Issue #3259603 by beagaliana: Add a fuctional test that checks the form...

  • beagaliana committed 34b0885 on 3259603-add-fuct-test
    Issue #3259603 by beagaliana: Move opening brace to the same line of the...

  • pcambra committed 6a44b06 on 3259603-fix-cod-standards authored by beagaliana
    Issue #3259603 by beagaliana: Add a fuctional test that checks the form...
  • beagaliana committed cd4e3c8 on 3259603-fix-cod-standards
    Issue #3259603 by beagaliana: Fix typo in directory name and move...

beagaliana’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.