Closed (fixed)
Project:
Drupal core
Version:
9.4.x-dev
Component:
ckeditor5.module
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
18 Jan 2022 at 16:23 UTC
Updated:
7 Feb 2022 at 15:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
wim leersComment #3
wim leersComment #4
wim leersThe patch in #3 did not apply to
9.3.x, only due to the dictionary being different in9.3.x.Here's the same patch uploaded again for
9.4.xand10.0.xand a different patch for9.3.x.Comment #5
lauriiiI think we should open an issue in our issue queue to track the upstream issue, and link it here.
Comment #6
wim leersDone: #3259367: [upstream] Allow configuring *which* HTML tags can be aligned.
Comment #7
lauriiiLooks good, thank you!
Comment #8
bnjmnmThis is such a nit that my dog is concerned about my visible embarrassment. These three @todo items exceed the 80 char limit. They should be extended to additional lines with a two space indent to indicate they're a continuation of the @todo
Comment #9
hooroomooUploaded same patches in #6 with added indents
Comment #10
hooroomooComment #11
hooroomooComment #12
hooroomooComment #15
bnjmnmIssue 3259179 landed earlier today, the changes introduced there makes this test outdated as the alignment operations have been split into individual plugins so enabling one does not automatically enable the others.
Comment #16
wim leers🤣🤣🤣🤣🤣🤣🤣🤣🤣🤣🤣🤣🤣🤣🤣🤣🤣🤣🤣🤣🤣🤣
Rebased now that #3259179: Split ckeditor5_alignment CKEditor 5 plugin, to allow for more precise upgrade path is in 👍 And now we have #3259593: Alignment being available as separate buttons AND in dropdown is confusing, which is the next way that this test coverage can be refined.
Comment #20
bnjmnmThis is now current with #3259179: Split ckeditor5_alignment CKEditor 5 plugin, to allow for more precise upgrade path so it's merged to 9.4.x/10.0.x as well as 9.3.x since CKEditor 5 is experimental and this is a non-disruptive expansion of test coverage.