It's a security risk waiting to happen and it complicates caching for group permission checks.

CommentFileSizeAuthor
#4 group-3259076-4.patch28.63 KBkristiaanvandeneynde
#2 group-3259076-2.patch12.13 KBkristiaanvandeneynde

Comments

kristiaanvandeneynde created an issue. See original summary.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Active » Needs review
StatusFileSize
new group-3259076-2.patch12.13 KB

Status: Needs review » Needs work

The last submitted patch, 2: group-3259076-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Needs work » Needs review
StatusFileSize
new group-3259076-4.patch28.63 KB

Right, can simplify a few tests now :)

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

somebodysysop’s picture

somebodysysop commented
Issue summary: View changes
Related issues: +#3315050: Sitewide Administrator permissions not working

I think this update may be causing another problem: site-wide administrator no longer has access to all groups.
https://www.drupal.org/project/group/issues/3315050