Problem/Motivation

The app.root and site.path services were converted to container parameters as Symfony 6 enforces services as objects, but these were strings that pretended to be services. This is critical to the Symfony 6 upgrade path.

Steps to reproduce

Proposed resolution

Remove these services and any tests relating to them.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3259024-2.patch3.25 KBlongwave

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review
StatusFileSize
new 3259024-2.patch3.25 KB
daffie’s picture

daffie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 3259024-2.patch, failed testing. View results

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs work » Reviewed & tested by the community

Looks like a random test failure to me, ordered a retest and put it back on RTBC per #3.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 3259024-2.patch, failed testing. View results

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs work » Reviewed & tested by the community

Hmmm, Yet Another Random Test Failure (I hope), retesting the retest.

  • catch committed 61bc211 on 10.0.x 
    Issue #3259024 by longwave: Remove deprecated 'app.root' and 'site.path...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed 61bc211 and pushed to 10.0.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.