Problem/Motivation

the yarn vendor-update command doesn't update core.libraries.yml file since #3231364: Add CKEditor 5 module to Drupal core.

Steps to reproduce

update ckeditor5 to latest release, see the libraries file not update.

Issue fork drupal-3258371

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nod_ created an issue. See original summary.

nod_ opened merge request !1642

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ at Acquia commented
Status: Active » Needs review
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +blocker
Related issues: +#3258250: Update to CKEditor5 v31.1.0

This same fix is part of #3258250: Update to CKEditor5 v31.1.0, and has proven to work very well there.

Trivial change, unblocking another core issue, that itself is blocking progress towards Drupal 10.

🚢

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Priority: Normal » Major

Bumping to Major because it blocks a Major issue.

  • lauriii committed e73a345 on 10.0.x 
    Issue #3258371 by nod_, Wim Leers: fix yarn vendor-update command

  • lauriii committed c2e3215 on 9.4.x 
    Issue #3258371 by nod_, Wim Leers: fix yarn vendor-update command

(...

  • lauriii committed 4711b76 on 9.3.x 
    Issue #3258371 by nod_, Wim Leers: fix yarn vendor-update command

(...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Version: 9.4.x-dev » 9.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed e73a345 and pushed to 10.0.x. Also cherry-picked to 9.4.x and 9.3.x. Thanks!

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ at Acquia commented

Thanks :)

nod_ closed merge request !1642

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.