Delete Entity Legal version [#3258368]

Problem/Motivation

I want to delete Entity Legal version(documents).

Steps to reproduce

Go to Entity Legal, edit and try to remove a version.

Proposed resolution

Create new routing.
Add 'delete' url in EntityLegalDocumentForm.
Create a new permission 'delete entity legal versions'.

User interface changes

Add a delete button in documents.

Issue fork entity_legal-3258368

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3258368-delete-entity-legal changes, plain diff MR !3
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

13 January 2022 at 08:59

saidatom created an issue. See original summary.

Comment #2

13 January 2022 at 09:01

saidatom opened merge request !3

Comment #3

saidatom

Lisbon

commented 13 January 2022 at 09:01

Status:

Active

» Needs review

Comment #4

dimilias commented 13 January 2022 at 14:07

Status:

Needs review

» Needs work

I have two more issues with the implementation. First, we are lacking tests.
Second, the module has 3 entities. EntityLegalDocument, EntityLegalDocumentVersion and EntityLegalDocumentAcceptance.
The acceptance entity holds users that have accepted a specific version. We need somehow to be able to cleanup these acceptances once a version is deleted.
Please, note, that this should not be done with a direct deletion. It would be better to be a batched or cron process because in a large scale website, there might be millions of entities to delete.

Comment #5

saidatom

Lisbon

commented 20 January 2022 at 08:48

Status:

Needs work

» Needs review

@idimopoulos delete the actual accepted versions was already implemented in old code. If you check delete from EntityLegalDocument they are deleting child's in that case documents and accepted versions. Do we need to implement that new approach to delete the accepted versions in batch/cron?

Comment #6

dimilias commented 23 January 2022 at 17:19

Status:

Needs review

» Reviewed & tested by the community

@saidatom, no the new changes suffice for the scope of the ticket. Users are now able to delete documents. If the accepted versions are also cleaned, that is fine for me. +1 RTBC here.