Problem/Motivation

Plugins should be deprecated in the constructor and not the main section of the class. This is because discovery and instantiation can result in triggering unwanted deprecations.

Steps to reproduce

See tests runs on #3252386: Use PHP attributes instead of doctrine annotations where all plugins have been reflected on for discovery.

Proposed resolution

Move deprecation to constructor,

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

N/a

CommentFileSizeAuthor
#2 3258014-2.patch2.81 KBalexpott

Comments

alexpott created an issue. See original summary.

alexpott’s picture

Status: Active » Needs review
Related issues: +#3252386: Use PHP attributes instead of doctrine annotations
StatusFileSize
new2.81 KB
kim.pepper’s picture

Status: Needs review » Reviewed & tested by the community

Reviewed. Code changes look straightforward.

  • catch committed c5bd67a on 10.0.x
    Issue #3258014 by alexpott: Fix plugin deprecations
    

  • catch committed 02a261e on 9.4.x
    Issue #3258014 by alexpott: Fix plugin deprecations
    
    (cherry picked from...
catch’s picture

Version: 9.3.x-dev » 9.4.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.0.x and cherry-picked to 9.4.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.