Problem/Motivation

Spin off from #3178534: Start running PHPStan on Drupal core (level 0) for baseline generation blockers.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3257654-2.patch6.57 KBmondrake

Comments

mondrake created an issue. See original summary.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Title: Fixes PHPStan 0 failures that cannot be included in baseline » Fix PHPStan L0 failures that cannot be included in baseline
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 3257654-2.patch6.57 KB
daffie’s picture

daffie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

mondrake’s picture

mondrake
Location 🇮🇹
commented

Also reported in #3257713: PHP 8.1 ComputedItemListTrait::offsetExists deprecation, so this will benefit of a backport down to 9.3

mondrake’s picture

mondrake
Location 🇮🇹
commented
Related issues: +#3257713: PHP 8.1 ComputedItemListTrait::offsetExists deprecation
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Category: Task » Bug report
Status: Reviewed & tested by the community » Fixed

Committed a0b2090 and pushed to 10.0.x. Thanks!
Committed a5f202d and pushed to 9.4.x and 9.3.x. Thanks!

The 9.x version does not have the changes to core/lib/Drupal/Core/Database/Connection.php because they conflicted and are not required.

Changing to a bug fix due to the annotation adding for PHP 8.1 compatibility. Implies we're missing some test coverage so will reopen the other issue to get it added.

  • alexpott committed a0b2090 on 10.0.x 
    Issue #3257654 by mondrake: Fix PHPStan L0 failures that cannot be...

  • alexpott committed a5f202d on 9.4.x 
    Issue #3257654 by mondrake: Fix PHPStan L0 failures that cannot be...

  • alexpott committed 7f3ab43 on 9.3.x 
    Issue #3257654 by mondrake: Fix PHPStan L0 failures that cannot be...
mondrake’s picture

mondrake
Location 🇮🇹
commented
Issue tags: +PHP 8.1

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.