Problem/Motivation

Note: As far as I know unnecessary code counts as a bug, but this could also be seen as a task (and then retargeted for 9.4?), not sure.

Found in #3257407: Use "content" region in BlockCreationTrait::placeBlock() instead of "sidebar_first".

SettingsTrayBlockFormTest's implementation of getTestThemes() is identical to that of it's parent SettingsTrayTestBase

Steps to reproduce

-

Proposed resolution

Remove SettingsTrayBlockFormTest::getTestThemes().

Remaining tasks

User interface changes

-

API changes

-

Data model changes

-

Release notes snippet

Issue fork drupal-3257600

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tstoeckler created an issue. See original summary.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Active » Needs review

tstoeckler opened merge request !1625

renatog’s picture

renatog commented
Issue tags: +Novice, +Portland2022

Adding Novice to the DrupalCon Portland 2022

renatog’s picture

renatog commented
Status: Needs review » Reviewed & tested by the community

BTW; I saw here and it's really makes sense. So moving that to RTBC

Thanks @tstoeckler

quietone’s picture

quietone commented
Version: 9.2.x-dev » 10.0.x-dev
Status: Reviewed & tested by the community » Needs work

Thanks for working on this.

It will need a 10.0.x version now, setting to NW.

rpayanm made their first commit to this issue’s fork.

rpayanm opened merge request !2332

andregp’s picture

andregp commented
Status: Needs work » Needs review

NR for #8

renatog’s picture

renatog commented
Status: Needs review » Reviewed & tested by the community

+1 to this. Seems good

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 10.0.x-dev » 9.4.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed bb3804f508 to 10.0.x and 480394b307 to 9.5.x and 8f20f776a0 to 9.4.x. Thanks!

Backported to 9.4.x as this is a low risk test only change.

  • alexpott committed bb3804f on 10.0.x 
    Issue #3257600 by tstoeckler, rpayanm: SettingsTrayBlockFormTest...

  • alexpott committed 480394b on 9.5.x 
    Issue #3257600 by tstoeckler, rpayanm: SettingsTrayBlockFormTest...

  • alexpott committed 8f20f77 on 9.4.x 
    Issue #3257600 by tstoeckler, rpayanm: SettingsTrayBlockFormTest...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.