Problem/Motivation
Note: As far as I know unnecessary code counts as a bug, but this could also be seen as a task (and then retargeted for 9.4?), not sure.
Found in #3257407: Use "content" region in BlockCreationTrait::placeBlock() instead of "sidebar_first".
SettingsTrayBlockFormTest
's implementation of getTestThemes()
is identical to that of it's parent SettingsTrayTestBase
Steps to reproduce
-
Proposed resolution
Remove SettingsTrayBlockFormTest::getTestThemes()
.
Remaining tasks
User interface changes
-
API changes
-
Data model changes
-
Release notes snippet
Issue fork drupal-3257600
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
tstoecklerComment #4
renatogAdding Novice to the DrupalCon Portland 2022
Comment #5
renatogBTW; I saw here and it's really makes sense. So moving that to RTBC
Thanks @tstoeckler
Comment #6
quietone CreditAttribution: quietone at PreviousNext commentedThanks for working on this.
It will need a 10.0.x version now, setting to NW.
Comment #9
andregp CreditAttribution: andregp at CI&T commentedNR for #8
Comment #10
renatog+1 to this. Seems good
Comment #11
alexpottCommitted and pushed bb3804f508 to 10.0.x and 480394b307 to 9.5.x and 8f20f776a0 to 9.4.x. Thanks!
Backported to 9.4.x as this is a low risk test only change.