Add a detailed view to SPA (AWS Cloud VPC Peering Connection)

CommentFileSizeAuthor
#7 dev1.dataninja.net_clouds_dashboard_aws_cloud_vpc_peering_connection_f6f5bd30-b143-4974-8eb6-0981fcb1fb9e(MacBook Air).png478.81 KByas

Issue fork cloud_dashboard-3256845

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

onotm created an issue. See original summary.

onotm opened merge request !17

onotm’s picture

onotm commented
Status: Active » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@onotm

Thank you for adding the view. I reviewed the patch and it looks good to me.

@ryo-yamashita

Could you please review the patch? Thanks!

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@onotm

I found that the Accepter CIDR Block item is missing. Can you add it? Thanks!

onotm’s picture

onotm commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new dev1.dataninja.net_clouds_dashboard_aws_cloud_vpc_peering_connection_f6f5bd30-b143-4974-8eb6-0981fcb1fb9e(MacBook Air).png478.81 KB

@onotm

Thank you for the update. I tested the patch and it looks good.

29.png

@ryo-yamashita

What do you think?

Ryo Yamashita’s picture

Ryo Yamashita commented

@yas

I have also checked the patch. It looks good to me, too.

Ryo Yamashita’s picture

Ryo Yamashita commented
Status: Needs review » Reviewed & tested by the community
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Needs work

@ryo-yamashita

Thank you for your review.

@onotm

Could you please rebase the patch? Thanks!

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Reviewed & tested by the community

@onotm

Thank you for the update. It looks good. I'll merge the patch to 4.x and close this issue as Fixed.

  • yas committed 28aea2a on 4.x authored by onotm 
    Issue #3256845 by onotm, yas, Ryo Yamashita: Add a detailed view to SPA...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.