Problem/Motivation

In #3197553: Deprecate drupal_js_defaults() we deprecated drupal_js_defaults() in drupal:9.4.0 and is removed from drupal:11.0.0.

As requested in #3197553-22: Deprecate drupal_js_defaults() we want to remove this in drupal:10.0.0

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#6 test_mr1598.png25.67 KBmurilohp

Issue fork drupal-3256518

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Spokje created an issue. See original summary.

Spokje opened merge request !1598

Spokje opened merge request !1599

spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs review

MR!1598: D9.4, changed deprecation message to mention removal in D10 instead of D11, changed deprecation test as well.
MR!1599: D10.0, removed drupal_js_defaults() and the deprecation test.

spokje’s picture

spokje
Primary language Dutch
commented
Assigned: spokje » Unassigned
murilohp’s picture

murilohp commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new test_mr1598.png25.67 KB

Both MR's looks good to me, just for a reference, I tested the specific test of MR1598. Using the command bellow:

php vendor/bin/phpunit -v -c /app/phpunit.xml core/tests/Drupal/KernelTests/Core/Asset/AttachedAssetsTest.php --filter testDeprecatedDrupalJsDefaults

And the test passed correctly:
test MR1598

About the MR1599, I checkout the branch 3256518-D10-Remove-drupal_js_defaults and searched for drupal_js_defaults on the base code(10.0.x) and nothing was found.

Moving to RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

@murilohp thanks for rtbc-ing this issue. Please do not attach screenshots of PHPUnit runs... the CI tells us this and it looks like an attempt to game the credit system.

Committed 2d52f94 and pushed to 10.0.x. Thanks!
Committed 038c7dd and pushed to 9.4.x. Thanks!

  • alexpott committed 2d52f94 on 10.0.x 
    Issue #3256518 by Spokje: Remove drupal_js_defaults() in D10 instead of...

  • alexpott committed 038c7dd on 9.4.x 
    Issue #3256518 by Spokje: Remove drupal_js_defaults() in D10 instead of...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Spokje closed merge request !1599

Spokje closed merge request !1598

quietone’s picture

quietone commented

Added this to the deprecation CR because this changes the deprecation message in 9.4.