Currently, the required CKEditor library has to be manually downloaded and stored in the libraries folder for the module to work. We should add composer.json which will ensure library is downloaded when module is installed and also add instructions if user wants to use project's composer.json file for this.
Install the module via composer.
Add composer.json file and instructions in the README.
NA
NA
NA
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
anagomes commentedComment #4
anagomes commentedHi @gaurav.kapoor. I added a composer.json file with the library as a requirement and a small comment on the README.txt, I hope everything is ok and according to what you expected. If you wish to alter or fix something, please let me know.
Comment #5
gaurav.kapoor commentedGreat work @anagomes. The MR looks good. Can you set commit message to 'Issue #3256101 by anagomes: Add composer.json file and also ensure required libraries are installed using it'. Thanks.
Comment #6
gaurav.kapoor commentedComment #9
gaurav.kapoor commentedI researched a little bit and noticed that there is a https://github.com/drupal-ckeditor-libraries-group which hosts all the CKEditor plugins. I have requested them to add the plugin for this module as well.
@anagomes Thanks for the MR, most of the required code is available, and that and whatever that has to be modified will be available once we have this repository created.
Comment #11
gaurav.kapoor commentedAdded the composer.json file which will also install the required library. Tested by installing the latest development release via composer and noticed that library is getting installed now.