Problem/Motivation

Add a detail view for cloud entity in cloud_dashboard SPA (AWS Cloud Elastic IP)

Issue fork cloud_dashboard-3255752

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sekinet created an issue. See original summary.

sekinet opened merge request !10

sekinet’s picture

sekinet commented
Status: Active » Needs work

@yas

I have created the patch. Could you please check it?

Thanks.

sekinet’s picture

sekinet commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Add a detail view for cloud entity in cloud_dashboard SPA (AWS Cloud Elastic IP) » Add a detailed view to SPA (AWS Cloud Elastic IP)

@sekinet

Thank you for adding the view. It looks good to me.

@ryo-yamashita

Could you please review the patch? Thanks!

Ryo Yamashita’s picture

Ryo Yamashita commented

@yas

I have also checked the patch. It looks good to me, too.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@ryo-yamashita

Thank you for your review. I'll merge the patch to 4.x and close this issue as Fixed.

  • yas committed 709ccc7 on 4.x authored by sekinet 
    Issue #3255752 by sekinet, yas, Ryo Yamashita: Add a detailed view to...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.