Problem/Motivation
Child issue from https://www.drupal.org/project/gutenberg/issues/3255691
The idea here is to fix all phpcs errors/warnings from the files found directly on the root directory.
Steps to reproduce
Open the Gutenberg module directory on your terminal and run the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml . -l > phpcs_gutenber__root.txt. You should end up with a file like the one attached bellow.
Proposed resolution
Fix the errors either automatically or manually and create a patch.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | phpcs_gutenberg__root_fixed.txt | 2.52 KB | andregp |
| #4 | 3255701-4.patch | 4.79 KB | andregp |
Comments
Comment #2
andregp commentedI'm working on this. :)
Comment #3
andregp commentedSorry, I posted on the wrong issue. Please, ignore the patch above.
Comment #4
andregp commentedThis patch should solve all phpcs errors. The only warnings left after applying this patch are regarding to README.md and CHANGELOG.md files which I believe should not be changed.
Comment #5
Matheus Macario commentedComment #6
Matheus Macario commentedreview done on Gutenberg's root files :
- Installed module
- Code review on changes made on the #4 patch (3255701-4)
- no errors popped out, except those warnings that you already mentioned on README.md and CHANGELOG.md, which i also think that shouldn't be modified.
Comment #8
marcofernandes commentedRegarding the named constants, we need to keep it as it is for now because they are set by the build script.