Demote routine content entity log entries from "notice" to "info"

Looks good++

Not clear why no tests affected

Let's get commiter's POV

Moving to 10.0.x where it needs to be applied first.

I applied the patch locally and ran git grep this\-\>logger\(\'content and found that BookAdminEditForm.php logs a notice when the title changes. In this patch when a node title changes an info level message is logged, unless I am reading the patch wrong. I think that needs to be changed. Setting to needs work.

+1, tested and reviewed patch #10 on Drupal 9.4.5

Tested #10 on Drupal 10.1.x

- The issue summary makes sense and provides the necessary details
- The patch applies cleanly
- The severity changes from notice to info
- Did a code review and there are no noticeable issues

Marking this issue as RTBC

Thanks for working on this.

Separating out the User module log messages made sense, because users are not like other content entities; they are associated with an account that has its own privileges on the site. However, for other content entities, I don't think we should be scoping these issues on a per-module basis. That creates unnecessary overhead. Reference:
https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquett...

I would recommend we make these changes across core consistently for content entity creation, update, etc. events. Certainly, #3309417: Demote routine block log entries from "notice" to "info" can be grouped with this issue, as can anything else performing similar operations on entities. If we need to split it up, it should be by operation, not by the specific entity type.

A quick grep gives the following potential list of modules with affected events:

[ayrton:drupal | Sun 17:20:51] $ grep -rl 'logger->notice' * | grep -v "vendor" | grep -v "node_modules"
core/lib/Drupal/Core/File/FileSystem.php
core/lib/Drupal/Core/Action/Plugin/Action/EmailAction.php
core/modules/migrate_drupal/src/FieldDiscovery.php
core/modules/contact/src/MailHandler.php
core/modules/locale/locale.bulk.inc
core/modules/locale/locale.module
core/modules/locale/locale.batch.inc
core/modules/comment/src/CommentTypeForm.php
core/modules/comment/src/CommentForm.php
core/modules/user/user.module
core/modules/user/src/EventSubscriber/UserFloodSubscriber.php
core/modules/block_content/src/BlockContentForm.php
core/modules/block_content/src/BlockContentTypeForm.php
core/modules/workspaces/src/Form/WorkspaceForm.php
core/modules/image/src/Controller/ImageStyleDownloadController.php
core/modules/search/src/Controller/SearchController.php
core/modules/system/src/Plugin/ImageToolkit/Operation/gd/Desaturate.php
core/modules/system/src/Plugin/ImageToolkit/Operation/gd/Rotate.php
core/modules/rest/src/Plugin/rest/resource/EntityResource.php
core/modules/media/src/MediaForm.php

From that list:

1. User was already reviewed
2. Comments, block content, book content, and media notices should be reviewed and handled in this issue
3. The instance in core/lib/Drupal/Core/File/FileSystem.php should be kept as a notice.
4. The mail handling operations in core/lib/Drupal/Core/Action/Plugin/Action/EmailAction.php and core/modules/contact/src/MailHandler.php might merit being downgraded to info messages, but are a different kind of thing, so could get their own issue scope.
5. The REST POST case should probably be considered in a separate issue, although it's interesting that there's no equivalent JSON:API POST message.
6. Worspaces are more than simply content so probably should be considered separately.
7. Locale can have its own issue.
8. The instances in core/modules/image/src/Controller/ImageStyleDownloadController.php, core/modules/system/src/Plugin/ImageToolkit/Operation/gd/Desaturate.php, and core/modules/system/src/Plugin/ImageToolkit/Operation/gd/Rotate.php should all be kept as notices.
9. The search module message should probably also be downgraded, but can be discussed on its own.

Additionally, we should maintain a single CR about this, rather than creating a ton of tiny ones. So let's use https://www.drupal.org/node/3259469 instead.

Adding credit for the duplicates.

The additional messages would need to be added to the CR.

Change record looks good
Issue summary is clear.
Tested out a few scenarios

Deleted a node -> info
Deleted a node revision ->info
Reverted a node revision -> info
Deleted a media -> info

Know there are others but seems all cases were covered.

Committed/pushed to 10.1.x, thanks!

Was looking at this issue. Not sure why andypost and ameymudras weren't credited for their contribution as they both seemed to contribute IMO but this issue is closed so maybe it won't be changed.

Why there's no follow-up for taxonomy and media?