Problem/Motivation

Child issue from https://www.drupal.org/project/gutenberg/issues/3255691
The idea here is to fix all phpcs errors/warnings from the files in the config/ directory.

Steps to reproduce

Open the Gutenberg module directory on your terminal and run the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml config/ > phpcs_gutenber_config.txt. You should end up with a file like the one attached bellow.

Proposed resolution

Fix the error and create a patch.

CommentFileSizeAuthor
#2 3255692-2.patch1007 bytesandregp
phpcs_gutenberg_config.txt808 bytesandregp

Comments

andregp created an issue. See original summary.

andregp’s picture

Assigned: andregp » Unassigned
Status: Active » Needs review
StatusFileSize
new1007 bytes

This folder had only one phpcs error so it was an easy fix.

Matheus Macario’s picture

Assigned: Unassigned » Matheus Macario
Matheus Macario’s picture

Assigned: Matheus Macario » Unassigned
Status: Needs review » Reviewed & tested by the community

review done on config/ :
- Installed module
- Code review on changes made on the #2 patch (3255692-2)
- it solves the errors, all good

  • marcofernandes committed 6e4c350 on 8.x-2.x
    Issue #3255692 by andregp, Matheus Macario, marcofernandes: PHPCS errors...
marcofernandes’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.