Problem/Motivation

Need to upgrade core requirements since D8 is EOL

Proposed resolution

- add ^10
- remove ^8 as core8 is EOL

User interface changes

No

API changes

No

Data model changes

No

CommentFileSizeAuthor
#6 set_new_core_version_requirements_2_3255270.patch11.75 KBmaximkashuba
#4 interdiff_0_1_325570.txt225 bytesmaximkashuba
#4 set_new_core_version_requirements_1_3255270.patch609 bytesmaximkashuba
#2 set_new_core_version_requirements_3255270.patch284 bytesmaximkashuba

Comments

temlife created an issue. See original summary.

maximkashuba’s picture

maximkashuba
Location Batumi
commented
StatusFileSize
new set_new_core_version_requirements_3255270.patch284 bytes
maximkashuba’s picture

maximkashuba
Location Batumi
commented
Status: Needs work » Needs review
maximkashuba’s picture

maximkashuba
Location Batumi
commented
StatusFileSize
new set_new_core_version_requirements_1_3255270.patch609 bytes
new interdiff_0_1_325570.txt225 bytes
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Needs work

1 test failed

maximkashuba’s picture

maximkashuba
Location Batumi
commented
StatusFileSize
new set_new_core_version_requirements_2_3255270.patch11.75 KB
maximkashuba’s picture

maximkashuba
Location Batumi
commented

@andypsot
the issue is dependent on the https://www.drupal.org/project/cmp_sirdata/issues/3254550
that's why i updated the patch copying the contents of another patch and changing the versions constratis to pass the tests failer.

The patch #6 passes D9 tests and fails test for D10 (https://www.drupal.org/pift-ci-job/2274435) but it looks like there is no problem in code but in constraints conflict between current module dev versions and proposed changes by the patch. Not sure how to fix it.

YurkinPark’s picture

YurkinPark commented

It seems like Drupal's CI validate versions which are stored in repository and apply patched version after composer finished. So, I guess this current state of module can not be tested with D10

andypost’s picture

andypost
he/him
Primary language Russian
commented

Please test 9.3/9.4 only D10 is changing now and could show unexpected errors

@maximkashuba please always provide interdiff.txt to follow/review changes you're made

temlife’s picture

temlife commented
Status: Needs work » Fixed
temlife’s picture

temlife commented
Status: Fixed » Needs review

Reopened issue so it can be reviewed and RTBC status can be set by reviewers (changes already included on the lastest review)

andypost’s picture

andypost
he/him
Primary language Russian
commented
Version: 1.0.x-dev » 1.0.0-rc6
Status: Needs review » Fixed

it was fixed via 87460a045cc9c07af6013e0ba1e1768ac2bbdb28

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.