Closed (fixed)
Project:
Rules
Version:
8.x-3.x-dev
Component:
Rules Core
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
17 Dec 2021 at 21:38 UTC
Updated:
3 Jan 2022 at 18:59 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
tr commentedComment #3
tr commentedHere is the dependency injection patch. No tests yet.
Comment #4
tr commentedHere's a new patch, which is the same as #3 but with tests and some changes to OptionsProviderBase.
Lessons learned from writing these tests:
Comment #5
tr commentedI cancelled the test in #4 because I uploaded an older version of the patch. Here's the correct version of the patch to test / review.
Comment #6
tr commentedNew patch with coding standards fixed. No functional changes.
Comment #7
jonathan1055 commentedExcellent analysis in #4. I have just checked the flattening you added, by hacking the
MessageTypeOptionsand introducing a two-level array to group the message type. It works fine, as shown by the attached.One more coding standard fault was introduced when you fixed the 8, so heres a new patch.
Comment #9
tr commentedThanks, I caught that too. Committed.