Problem/Motivation

In #2934995: Add a "Manage permissions" tab for each bundle that has associated permissions, we deprecated a service and the related (route enhancer) class. That issue was initially fixed in the 9.3.x branch, but it was reverted shortly before Drupal 9.3.0 was released. It was not reverted in the 9.4.x branch.

The deprecation notices refer to Drupal 9.3.0.

Proposed resolution

Update the deprecation notices to refer to 9.4.0.

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

N/A

Issue fork drupal-3254866

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

benjifisher created an issue. See original summary.

benjifisher opened merge request !1556

benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
commented
Status: Active » Needs review

MR !1556 updates the deprecation notices.

By the way, the change records for #2934995: Add a "Manage permissions" tab for each bundle that has associated permissions already reference 9.4.0:

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Reviewed & tested by the community

It's fine to deprecate in 9.4 for Drupal 10.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Now that #3261241: Remove deprecated field module functions has landed this only needs to go in 9.4.x - it doesn't and will never apply to 10.0.x

  • catch committed 9aabbee on 9.4.x 
    Issue #3254866 by benjifisher, alexpott: Update the deprecation notices...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed 9aabbee and pushed to 9.4.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

After discussing with @catch we decide to revert #2934995: Add a "Manage permissions" tab for each bundle that has associated permissions from 9.4.x as the follow-up still has not landed that will make the change compatible with the groups module. So we will need to do this issue again on 9.5.x / 10.x

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

We managed to land #3253955: Let modules opt in to the bundle-specific permissions form in 9.4.x so the deprecation notices are now correct on all branches. Yay.