Problem/Motivation

The current phpstan support only does deprecation testing and doesn't support doing actually analysis when you project provides its own phpstan.neon. Related, if that static analysis uses phpstan/extension-installer and has it in its composer.json the hardcoded version kinda blows up.

Steps to reproduce

Create a project with phpstan.neon.
Enable phpstan support in drupalci.yml

Proposed resolution

Auto-detect the existence of phpstan.neon and us it instead of the hard coded version maybe? Provide a separate "deprecation" only plugin?

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork drupalci_testbot-3254634

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

neclimdul created an issue. See original summary.

neclimdul’s picture

neclimdul
He/Him
commented

understandably this may never be implemented here with the gitlab work going on but wanted to capture it.

neclimdul opened merge request !3

neclimdul’s picture

neclimdul
He/Him
commented
Status: Active » Needs review

Merge request with a possible quick fix that only adds and uses the hardcoded rules if there isn't an existing config. This would make adding a phpstan.neon file "work as expected" and not require any hackery to run phpstan in drupalci.

hestenet made their first commit to this issue’s fork.