When loading a D7 site that has Views PHP installed, I get the message below when opening the site.
DEPRECATED: REQUIRED PARAMETER $INPUT FOLLOWS OPTIONAL PARAMETER $CHECKBOX IN ...\SITES\ALL\MODULES\VIEWS_PHP\VIEWS_PHP.MODULE ON LINE 44
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 3254385-4.patch | 7.65 KB | andregp |
Issue fork views_php-3254385
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
frank.schram commentedComment #3
andregp commentedIts a simple case of changing the order of parameters to follow Drupal standard of letting all optional parameters at last.
I'll fix it.
Comment #4
andregp commentedChanged the order of parameter on the function views_php_form_element() (on views_php.module) and then changed all calls to this function on the other files accordingly.
Comment #6
andregp commentedComment #7
liam morlandThanks for the patch.
Changing the order of the parameters would break any code that uses this. The correct fix is to remove the default value from any parameter that is followed by a parameter without a default value.
Please put the fix into an issue fork.
Comment #8
andregp commentedHi Lian, I made the change as you asked for, added on a issue fork, and made a merge request.
Comment #10
andregp commentedComment #12
liam morlandThanks!