Problem/Motivation

Currently autoloader-suffix in core's composer.json is Drupal9

Proposed resolution

Remove the autoloader suffix. It was introduced in #2176265: Set an explicit ["config"]["autoloader-suffix"] in composer.json to avoid noise on composer update. when vendor was committed to the repo, this hasn't been the case for a long time now. This only affects core developers because they are the only ones using the root composer.json; individual sites using drupal/core won't be affected.

Remaining tasks

patch/review/commit

User interface changes

no

API changes

no

Data model changes

no

Release notes snippet

CommentFileSizeAuthor
#12 3254149-12.patch324 bytesandypost
#9 3254149-9.patch324 byteslongwave
#4 3254149-2.patch366 bytesandypost
#3 3254149-3.patch365 bytesSpokje
#2 3254149-2.patch366 bytesandypost
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

andypost created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
FileSize
3254149-2.patch366 bytes

the patch

Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje commented
FileSize
3254149-3.patch365 bytes
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
FileSize
3254149-2.patch366 bytes

re-uploading patch from #2 as it applies cos #3253683: Improve compatibility with composer 2.2 is commited

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented

Technically a duplicate of #3252262: [Drupal 10] Update autloader-suffix in composer.json which was first, and I have the same question: why do we need the version number here? Can we just use "Drupal"?

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Related issues: +#3252262: [Drupal 10] Update autloader-suffix in composer.json
longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented

Looking back to when this was first introduced: #2176265: Set an explicit ["config"]["autoloader-suffix"] in composer.json to avoid noise on composer update.

This was done to reduce noise in composer update patches, back when we had vendor in the repo, including the autoloader. This is no longer the case so I think we can probably drop this entirely now, and fall back to Composer generating a random string instead?

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented

Also, this autoloader-suffix only affects core developers, because they are the only ones that use the root composer.json. It's not set in core/composer.json so site autoloaders get a random suffix anyway.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Title: Update autoloader-suffix to Drupal10 » Remove config.autoloader-suffix from composer.json
Issue summary: View changes
FileSize
3254149-9.patch324 bytes

Repurposed the issue following #7/#8 - please change this back if I am wrong about this!

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Needs review » Reviewed & tested by the community

As it affects only core devs, then ready to go

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Needs review

Needs a re-roll.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
FileSize
3254149-12.patch324 bytes

re-roll

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs review » Reviewed & tested by the community

Thanks @andypost.

  • catch committed d787fa2 on 10.0.x 
    Issue #3254149 by andypost, longwave, Spokje: Remove config.autoloader-...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed d787fa2 and pushed to 10.0.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.