Problem/Motivation

\Drupal\Tests\update\Functional\UpdateTestBase::setUp()

Is only needed for FileTransferAuthorizeFormTest and UpdateUploadTest

All other test classes that extend UpdateTestBase would pass without these. But if you were trying work on these tests this would be very hard for you to understand. I am the maintainer of the Update I even had to just remove this method and see what broke.

Leaving this method where it is bad because:

  1. It risks us making accidently a change that means other classes will only pass with method running
  2. It makes that tests take longer because it make directory for every test case, and there are a lot
  3. It makes understanding the tests harder because you can't rule that this method is affecting the test you are trying to understand

Proposed resolution

Remaining tasks

Issue fork drupal-3253639

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

tedbow created an issue. See original summary.

longwave’s picture

Status: Active » Reviewed & tested by the community

+1 for simplifying test base classes so they are easier to understand, this makes sense to me.

  • catch committed 42a48a2 on 10.0.x
    Issue #3253639 by tedbow, longwave: \Drupal\Tests\update\Functional\...

  • catch committed 73a154a on 9.4.x
    Issue #3253639 by tedbow, longwave: \Drupal\Tests\update\Functional\...
catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.0.x and cherry-picked to 9.4.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.