Problem/Motivation
\Drupal\Tests\update\Functional\UpdateTestBase::setUp()
Is only needed for FileTransferAuthorizeFormTest and UpdateUploadTest
All other test classes that extend UpdateTestBase would pass without these. But if you were trying work on these tests this would be very hard for you to understand. I am the maintainer of the Update I even had to just remove this method and see what broke.
Leaving this method where it is bad because:
- It risks us making accidently a change that means other classes will only pass with method running
- It makes that tests take longer because it make directory for every test case, and there are a lot
- It makes understanding the tests harder because you can't rule that this method is affecting the test you are trying to understand
Proposed resolution
Remaining tasks
Issue fork drupal-3253639
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
longwave+1 for simplifying test base classes so they are easier to understand, this makes sense to me.
Comment #6
catchCommitted/pushed to 10.0.x and cherry-picked to 9.4.x, thanks!