The starterkit theme at the moment contain some pretty specific templates, such as ones that are rendering the media library. I don't think we should move the maintenance burden of those templates to the theme maintainers by default, since I assume that most themes won't be providing custom markup for some of the templates like media library.
Identify list of templates to remove from starterkit theme. In #3280059: Mark "product" related templates and CSS internal some of those should be marked internal both in the modules and Stable themes.
Several unneeded templates and their corresponding assets were removed from the default Starterkit generated theme. Review the change record for information on specific templates.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | interdiff.txt | 463 bytes | lauriii |
| #7 | 3253286-7.patch | 56.86 KB | lauriii |
| #6 | 3253286-6.patch | 56.82 KB | lauriii |
| #4 | 3253286-4.patch | 38.71 KB | lauriii |
Comments
Comment #2
lauriiiWe have started composing a list of templates to mark internal in https://docs.google.com/spreadsheets/d/1ljrNuDr_UgQJGjhH1CDjPbx7aRODnaOJ...
Comment #3
ckrinaMost of the templates existing right now in Starterkit come from Classy, right? Because for most of them the main improvement they add is adding extra classes and markup to the core ones. So I guess the dilemma would be to ship core with very few classes or give this option to override that.
One question I'd have is if starterkit need to ship with folders like
content-editthat provide templates to edit content.Comment #4
lauriiiI'm changing the proposal to do the actual mechanics of marking templates in a follow-up since it shouldn't be a hard requirement for starterkit theme. The hard requirement for starterkit theme is to remove templates we don't want everyone to override because we might want to change them later in core. Here's a patch which is based on the work that we did on the spreadsheet in #2. On top of that, I removed templates related to Book, RDF, Aggregator, and Forum in preparation to those modules being removed from core, and also not mapping to the 80% use case.
Comment #5
lauriiiComment #6
lauriiiWent ahead and also removed CSS, libraries and preprocess functions related to the templates I'm proposing to remove in #4.
Comment #7
lauriiiComment #8
lauriiiDiscussed with @xjm and she pointed out that we need a change record for this.
Comment #9
catchGood idea to trim down starterkit first. Re-titling to reflect current status.
Comment #10
bnjmnmI created & composed a change record and reviewed the patch. The templates chosen for review have a good rationale, and it looks they & the related assets were properly removed.
Comment #11
lauriiiCR looks great!
Also opened follow-up for marking some of those templates internal.
Comment #13
alexpottI agree that a smaller starterkit to start with is helpful. We can always add things later - and remove other things. That's one of the points of doing this work in the first place.
Committed 4713051 and pushed to 10.0.x. Thanks!
Committed and pushed 3fe2df7177 to 9.5.x and 3680d86a12 to 9.4.x. Thanks!